Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multi-select): add onListScrollBottom #7044

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat(multi-select): add onListScrollBottom #7044

merged 2 commits into from
Dec 10, 2024

Conversation

tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Oct 25, 2024 •
edited
Loading

fix #6752

Proposed behaviour

adds the onListScrollBottom callback to MultiSelect, to be called when a user scrolls to the bottom of the select list

Current behaviour

Currently, there is no onListScrollBottom callback on MultiSelect

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@tomdavies73 tomdavies73 self-assigned this Oct 25, 2024
@tomdavies73 tomdavies73 requested review from a team as code owners October 25, 2024 13:46
@tomdavies73 tomdavies73 marked this pull request as draft October 25, 2024 13:46
@tomdavies73 tomdavies73 force-pushed the FE-6864 branch 4 times, most recently from a1de7e7 to 334d335 Compare October 28, 2024 11:20
@tomdavies73
feat(multi-select): add onListScrollBottom
daeb37a 
adds the onListScrollBottom callback, to be called when a user scrolls to the bottom of the select
list

fix #6752
@tomdavies73 tomdavies73 changed the title feat(multi-select, simple-select): add listActionButton & onListAction feat(multi-select): add onListScrollBottom Dec 5, 2024
@harpalsingh harpalsingh marked this pull request as ready for review December 9, 2024 12:42
@tomdavies73 tomdavies73 merged commit 24e67d4 into master Dec 10, 2024
24 checks passed
@tomdavies73 tomdavies73 deleted the FE-6864 branch December 10, 2024 13:59
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrobinson88 paulrobinson88 paulrobinson88 approved these changes

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

Assignees

@tomdavies73 tomdavies73

Labels
Passed QA Passed Review Passed UX QA released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MutiSelect: add onListScrollBottom prop.
6 participants
@tomdavies73 @carbonci @edleeks87 @damienrobson-sage @paulrobinson88 @harpalsingh