Delete enzyme #7051
Merged
Delete enzyme #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
force-pushed
the
delete-enzyme
branch
from
5e16c89 to
c024fab
Compare
edleeks87
added
Pending Review
No QA Required
No UX QA Required
Squad Front End
and removed
DO NOT MERGE
labels
Parsium
approved these changes
Nov 5, 2024
|
LGTM! 👍🏼 |
|
🎉 This PR is included in version 144.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Remove enzyme, related packages and utils
Rename RTL based styled-system test utils
I have increased the timeout by 2.5 seconds when running locally (no issues in CI) as I and other devs have noticed intermittent timeouts on some tests FE-6888 has been raised to investigate the cause and if we can reduce the timeout again
Current behaviour
Enzyme and related packages still installed
Some styled-system test utils have not been renamed
QA
Additional context
Testing instructions