fix(select): ensure select-list has correct box-shadow when placement is top #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is top Adds correct box-shadow style to select-list when placement is "top". fix #7125
nuria1110
commented
Dec 19, 2024
| box-shadow: var(--boxShadow100); | ||
| box-shadow: ${({ placement }) => | ||
| placement === "top" | ||
| ? "0 -5px 5px 0 #00141e33, 0 -10px 10px 0 #00141e1a" |
There was a problem hiding this comment.
There is no design token for this so I just negated the y-offset of the original token value.
There was a problem hiding this comment.
Are there any design tokens that could be used instead of those hex colours?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7125
Proposed behaviour
Select-list has correct box-shadow when placement is "top".
Current behaviour
Select-list does not have correct box-shadow when placement is "top".
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
See "List Placement" story.