test: improve robustness of Playwright tests #7139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rance/disappearance
…aviour Removed tests focused on the lazy loading behaviour managed by the test wrapper. This behaviour is not a built-in feature of `FilterableSelect` so the tests did not reflect its out-of-box functionality. The test suite now focuses on verifying `FilterableSelect`'s native behaviour based on its props and interactions with its rendered UI.
…en covered by Jest
Removed tests focused on the lazy loading behaviour managed by the test wrapper. This behaviour is not a built-in feature of `MultiSelect` so the tests did not reflect its out-of-box functionality. The test suite now focuses on verifying `MultiSelect`'s native behaviour based on its props and interactions with its rendered UI.
Removed tests focused on the lazy loading behaviour managed by the test wrapper. This behaviour is not a built-in feature of `SimpleSelect` so the tests did not reflect its out-of-box functionality. The test suite now focuses on verifying `SimpleSelect`'s native behaviour based on its props and interactions with its rendered UI.
Parsium
force-pushed
the
improving-pw-performance
branch
from
40d7dd5 to
1c5cd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Updated Playwright tests for the following Carbon components to enhance reliability:
DateDialogFullscreenPortalSimpleSelectFilterableSelectMultiSelectSimpleColorPickerTextEditorToastKey changes made:
waitFor()or explicit assertions that check for element appearance/disappearance at critical moments. Ensures UI has reached the expected state before the test proceeds, minimising the risk of flakiness due to synchronisation issues.Current behaviour
A collection of Playwright tests have a high flakiness rate. This reduces overall reliability of the test suite, and increases development time.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions