Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline 1.0 fails on CS comprehension idioms #302

Closed
bjouhier opened this issue Nov 4, 2015 · 3 comments
Closed

Streamline 1.0 fails on CS comprehension idioms #302

bjouhier opened this issue Nov 4, 2015 · 3 comments
Assignees
Labels

Comments

@bjouhier
Copy link
Member

bjouhier commented Nov 4, 2015

See #298

Repro:

nodes = (@createTestNode suite, _ for i in [0...numNodes])

And here's the JS that compiles to:

nodes = (function() {
  var j, ref, results1;
  results1 = [];
  for (i = j = 0, ref = numNodes; 0 <= ref ? j < ref : j > ref; i = 0 <= ref ? ++j : --j) {
    results1.push(this.createTestNode(suite, _));
  }
  return results1;
}).call(_this);
@bjouhier
Copy link
Member Author

bjouhier commented Nov 4, 2015

@aseemk
Streamline does not handle the idiom with _this, just this. Should be easy to fix.

@bjouhier bjouhier added the bug label Nov 4, 2015
@bjouhier bjouhier self-assigned this Nov 4, 2015
@aseemk
Copy link
Contributor

aseemk commented Nov 4, 2015

Thanks @bjouhier!

@bjouhier
Copy link
Member Author

bjouhier commented Nov 4, 2015

@aseemk You're welcome 😄

I'm going to stop here for the day. I'll fix #301 and #297 tomorrow and I will republish to NPM. I'll look at the other ones a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants