Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all subject names to use device name prefix #432

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

glopesdev
Copy link
Collaborator

This PR refactors all subject names in the social workflows to adopt prefix based naming, following the convention for device streams, where streams are contained inside device folders with individual files taking up the folder name as a prefix.

RFID device names were also refactored to follow a nesting convention from outer to inner, e.g. NestRfid1 instead of RfidNest1.

Finally, the logging was unified across AEON3 and AEON4 as they now share the same hardware.

Fixes #431

@glopesdev glopesdev added feature New feature or request fix Pull request that fixes an issue labels Dec 20, 2023
@glopesdev glopesdev added this to the Social0.1 milestone Dec 20, 2023
@glopesdev glopesdev merged commit f93b6b7 into social Dec 20, 2023
@glopesdev glopesdev linked an issue Dec 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for include workflow subject naming conventions
1 participant