Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored patch controller commands from control panel #553

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

aspaNeuro
Copy link
Contributor

@aspaNeuro aspaNeuro commented Jun 7, 2024

Patch controller commands are routed to a behavior subject with no default starting value or state recovery, which means there is no need to skip notifications on subscription.

Fixes #479

@aspaNeuro aspaNeuro added bug Something isn't working bonsai-workflow Requires modifications to the structural acquisition workflow AEON3 Experimental rig in room B2-210 AEON4 Experimental rig in room B2-208 labels Jun 7, 2024
@aspaNeuro aspaNeuro added this to the Social0.3 milestone Jun 7, 2024
@aspaNeuro aspaNeuro requested review from glopesdev and jkbhagatio June 7, 2024 15:52
@jkbhagatio jkbhagatio linked an issue Jun 7, 2024 that may be closed by this pull request
@glopesdev glopesdev changed the title Remove skip 1 from patches controller Fix ignored patch controller commands from control panel Jun 8, 2024
@glopesdev glopesdev merged commit 11691ae into social Jun 8, 2024
@glopesdev glopesdev deleted the buttons-need-click-twice branch June 8, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AEON3 Experimental rig in room B2-210 AEON4 Experimental rig in room B2-208 bonsai-workflow Requires modifications to the structural acquisition workflow bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch Visualizer GUI buttons need to be clicked twice
2 participants