Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Exception logging #97

Merged
merged 5 commits into from
Sep 15, 2024
Merged

[ADD] Exception logging #97

merged 5 commits into from
Sep 15, 2024

Conversation

hullabaloo-vincent
Copy link
Contributor

Resolves #94

@hullabaloo-vincent hullabaloo-vincent added the enhancement New feature or request label Sep 15, 2024
@hullabaloo-vincent hullabaloo-vincent self-assigned this Sep 15, 2024
@hullabaloo-vincent hullabaloo-vincent linked an issue Sep 15, 2024 that may be closed by this pull request
Error logging system / Additional exceptions #94
Closed
@AlexKollar
Copy link
Collaborator

AlexKollar commented Sep 15, 2024 •
edited
Loading

@hullabaloo-vincent Did my best to recreate the error issue in mention in the video linked below.
https://github.com/user-attachments/assets/ccfd2d56-60de-4621-9a50-60d6cf1e06a6

Steps:

  1. Commented out the import getpass
  2. lunched navi - Error flashed but vanished
  3. checked log file - empty.

I did however see something new pop up instead of a stream of error data So I think the error handling works for navi output. Its just really really fast and does not log to the file.

@AlexKollar
Copy link
Collaborator

Tested and working.

@AlexKollar
Copy link
Collaborator

image
Wham bam! It works!

AlexKollar
AlexKollar approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@AlexKollar AlexKollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@AlexKollar AlexKollar merged commit a13eada into edge Sep 15, 2024
1 check was pending
@hullabaloo-vincent hullabaloo-vincent deleted the vincent/crash-logging branch October 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKollar AlexKollar AlexKollar approved these changes

Assignees

@hullabaloo-vincent hullabaloo-vincent

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error logging system / Additional exceptions
2 participants
@hullabaloo-vincent @AlexKollar