Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt remove mypy #410

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Update requirements.txt remove mypy #410

merged 3 commits into from
Dec 25, 2024

Conversation

jbampton
Copy link
Member

We run mypy with pre-commit so it should be self contained

We run mypy with pre-commit so it should be self contained
@BaseMax
Copy link
Member

BaseMax commented Dec 25, 2024

Also we can delete types-PyYAML from root, we need to have types-PyYAML inside config dir.

@BaseMax
Copy link
Member

BaseMax commented Dec 25, 2024

And please update requirements.txt file in the config dir.

@BaseMax
Copy link
Member

BaseMax commented Dec 25, 2024

requirements.txt in config and portal dir

@BDadmehr0 Maybe you can do it as next PR.

Many thanks

@BaseMax BaseMax merged commit 63c866f into main Dec 25, 2024
13 of 15 checks passed
@BaseMax BaseMax deleted the jbampton-patch-1 branch December 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants