Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress login required and not supported on UserSession close #169

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Suppress login required and not supported on UserSession close #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion huawei_lte_api/api/User.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
LoginErrorUsernamePasswordWrongException, \
LoginErrorUsernameWrongException, \
LoginErrorPasswordWrongException, \
ResponseErrorLoginRequiredException, \
ResponseErrorNotSupportedException

DEFAULT_USERNAME = 'admin'
Expand All @@ -27,7 +28,11 @@ def __init__(self, session: Session, username: str = DEFAULT_USERNAME, password:
self.user.login(username, password, True)

def close(self) -> None:
self.user.logout()
try:
self.user.logout()
except (ResponseErrorLoginRequiredException, ResponseErrorNotSupportedException):
# Idempotency/nothing further to do, suppress
pass

def __enter__(self) -> 'UserSession':
return self
Expand Down