Clean up Page Designer Code #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraya
reviewed
Feb 24, 2023
| + path: '/page-viewer/:pageId', | ||
| + component: PageViewer | ||
| + }, | ||
| ``` |
There was a problem hiding this comment.
Do we want to include instructions to visualize the page?
E.g.
- Run the dev server.
npm run start --prefix packages/template-retail-react-app/
- Navigate to the page-viewer URL with the Page designer page id.
http://localhost:3000/page-viewer/{page-id}
http://localhost:3000/page-viewer/homepage-example
There was a problem hiding this comment.
I can probably add a note about the route, but I think stating the dev server is covered elsewhere.
There was a problem hiding this comment.
I add some additional verbage for those that might take the sample code for production code.
Co-authored-by: Adam Raya <adamraya@users.noreply.github.com>
Co-authored-by: Adam Raya <adamraya@users.noreply.github.com>
…CommerceCloud/pwa-kit into page-designer-cleanup
adamraya
approved these changes
Feb 25, 2023
bfeister
added a commit
that referenced
this pull request
Feb 28, 2023
* develop: Support Node 16 (#965) [W-12450361] Introduce short-circuit method for bypassing auth in Commerce Provider by passing in a fetchedToken (#1010) remove jest-silent-reporter (#1009) Clean up Page Designer Code (#1004) [Shopper Experience] `ImageWithText` component (#991) Feature: Page Designer Carousel Component (#977) [Feature] Page Designer Layout Components WIP (#993) remove updatePw from not implemented list (#996) Back-port Shopper Experience Base Components into Retail Template (#992) # Conflicts: # packages/commerce-sdk-react/package-lock.json # packages/commerce-sdk-react/package.json # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-dev/src/configs/webpack/config.js # packages/template-retail-react-app/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR to clean up and organize the files and exports after both myself and adam have make contributions to the page designer work. I've also created a small README that lives inside the new
page-designerfolder to explain what the folder structure is and how to use the page component.