Fix NPM dependencies

[adamraya]

Description

The PR uses NPM 8 to re-generate the lock files using lockfileVersion:2 which is backwards compatible with lockfileVersion:1 solving the NPM warning npm WARN old lockfile.

Regenerating lock files using NPM 8 uncovered a few problems with the dependencies resolution in our package.json files.

These are the changes done to successfully re-generate lock files using NPM 7 or 8:

Package template-retail-react-app

• Add @chakra-ui/system v1 to prevent downloading an incompatible v2.
• Add @testing-library/dom to devDependecies since is used by some tests:
  

  pwa-kit/packages/template-retail-react-app/app/components/icons/index.test.js

  Line 8 in d64503d

  import {within} from '@testing-library/dom'

Package pwa-kit-react-sdk

• Remove enzyme-adapter-react-16. Since requires react@16 and we currently use react@17.

Generator script

After re-generating the package-lock.json files, the generator script was stuck waiting for the local NPM Verdaccio.
A recent change made in the integration hooks branch on a PR also regenerating lock files seems to solve that problem here as well.

---

The PR also fixes a Warning when pushing a bundle to MRT using Node 16.
The change is backwards compatible with Node 14.

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

How to Test-Drive This PR

Verify we can re-generate lock files using NPM 8.

1. Checkout this branch fix-npm-peer-dependencies. Remove node_modules folders and package-lock.json files

git clean -dxf && find . -name 'package-lock.json' -type f -delete

2. Switch to NPM 7 or NPM 8

nvm use 16.19

3. Install dependencies

npm install

4. Confirm lock files are being generated.

---

Verify we don't see a warning when pushing a bundle to MRT using Node 16.

1. Using Node 16, run the npm run push command to push a bundle to an MRT environment.
2. Verify there're no Node 16 warnings in the terminal.

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[bendvc]

Interesting that we didn't clean this up before. Nice catch

[bendvc]

Hey @adamraya, Back to the original question, which was what happens how when a dev runs npm ci when they are using npm 6? I think we wanted to know if those users were going to see a warning about the package-lock files having to be re-created or would npm6 know how to use those files created with npm 8.

[adamraya]

Hey @adamraya, Back to the original question, which was what happens how when a dev runs npm ci when they are using npm 6? I think we wanted to know if those users were going to see a warning about the package-lock files having to be re-created or would npm6 know how to use those files created with npm 8.

The generated lock files using NPM 8 use lockfileVersion:2 and are backwards compatible with lockfileVersion:1
https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#lockfileversion:~:text=The%20lockfile%20version%20used%20by%20npm%20v7%2C%20which%20is%20backwards%20compatible%20to%20v1%20lockfiles

I confirmed this by removing the node_modules folders and running npm ci using NPM 6.

[bfeister]

Awesome, thanks for fixing @adamraya 🙏

LGTM