Increase test timeouts only on CI env #1123
Merged
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives some breathing room to the CI tests, so that any document queries or other things that may run intermittently slower can still finish without running into timeouts (timeouts from either react-testing-library or Jest).
In your local machine though, the tests should run much faster and thus not needing the increased timeouts there.
How to test the changes
To verify that local tests still fail fast with the default timeouts, try updating one of the Checkout tests like this:
Then run the test by
npm run test -- "./app/pages/checkout/index.test.js --no-coverage"
.The FOO timer should last for around the default 1 sec (and not 6 seconds).
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization