[v3] Fix dev server not able to serve static files #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinxh
changed the title
|
closed as this is a dup #1196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dev server has a bug where it fails to serve static files. This PR aims to fix the issue.
The bug was introduced in a402f66#diff-3c62fd04e584e6cbc2443d75ef447133665c8c21a1b34e0fa8b9d5a29cd88808 I don't exactly know why the CopyPlugin is moved to
ssr.jswebpack config, but that config is for production only.This PR fixes the issue by ensuring the static files are copied into the build folder on both development and production environment.
verified change on production too https://scaffold-pwa-test-env.mobify-storefront.com/
Changes
CopyPluginfor static files is included in dev webpack configsHow to Test-Drive This PR