Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v3 preview release - @W-13481576@ #1233

Merged
merged 318 commits into from
May 30, 2023
Merged

Prepare for v3 preview release - @W-13481576@ #1233

merged 318 commits into from
May 30, 2023

Conversation

vmarta
Copy link
Contributor

@vmarta vmarta commented May 29, 2023 •
edited
Loading

  • For all public packages, prefixing all the versions with @salesforce/
    • plus, updating all corresponding references to them
  • and setting version 1.0.0-dev for both retail-react-app and commerce-sdk-react packages.

Todos:

  • build and run retail-react-app
  • test running the generator
  • pass CI tests (while disabling check-dependencies.js for now)

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

yunakim714 and others added 30 commits March 30, 2023 11:59
@yunakim714
rewrite requestcontext.request for path with caret
2eecb75
@yunakim714
perform overrideshashmap lookup for relative import
3766818
@yunakim714
merge v3 and regenerate lock files with version 2
24bb5c3
@yunakim714
progress
1b42d87
@yunakim714
fix conflicts
6fd8cdd
@bfeister
fix package lockfiles that were out of sync
7f3c364
@bfeister
Revert "fix package lockfiles that were out of sync"
f0900d5 
This reverts commit 7f3c364.
@yunakim714
progress
9a2252c
@bfeister
fix out of sync lockfiles
f4e332e
@bfeister
Merge branch 'v3' into feature/template-extensibility
b2cad1d 
* v3:
  Drop npm 6 and node 14 from V3 (#1112)
  Upgrade lerna (#1111)
  add locale and currency to apiClients (#1107)
  Update test.yml (#1109)
  [V3] Invoke push action for v3 to `staging-v3` target (#1108)
  remove commerce api folder (#1105)

# Conflicts:
#	package-lock.json
#	package.json
#	packages/commerce-sdk-react/package-lock.json
#	packages/commerce-sdk-react/package.json
#	packages/internal-lib-build/package-lock.json
#	packages/pwa-kit-create-app/package-lock.json
#	packages/pwa-kit-create-app/package.json
#	packages/pwa-kit-dev/package-lock.json
#	packages/pwa-kit-dev/package.json
#	packages/pwa-kit-react-sdk/package-lock.json
#	packages/pwa-kit-runtime/package-lock.json
#	packages/template-retail-react-app/app/mocks/mock-data.js
#	packages/template-retail-react-app/package-lock.json
#	packages/template-typescript-minimal/package-lock.json
#	packages/test-commerce-sdk-react/package-lock.json
@yunakim714
merge feature branch back
b4ef5b9
@yunakim714
resolve merge conflicts
93727d1
@bfeister
Merge branch 'v3' into feature/template-extensibility
d664877 
* v3:
  Sort contents of package.json files. (#1115)
  Fail fast? False! (#1116)

# Conflicts:
#	packages/pwa-kit-create-app/package.json
#	packages/pwa-kit-dev/package.json
#	packages/pwa-kit-runtime/package.json
#	packages/template-typescript-minimal/package.json
@bfeister
merge conflict
a11bbcc
@bfeister
resolve merge conflict
34dc3f0
@bfeister
update spike project's engines / regen v3 lockfiles
ca6a625
@yunakim714
regenerate lock files
3863783
@bfeister
add missing node engines
c562975
@bfeister
add missing useToast (bad merge)
cee6d04
@bfeister
updates from underlying template-retail-react-app
dfb656b
@bfeister
drop unnecessary pages/product-detail override
5f364df
@bfeister
Merge branch 'feature/template-extensibility' into extensibility-code…
cc30d3a 
…-rehaul

* feature/template-extensibility:
  drop unnecessary pages/product-detail override
  updates from underlying template-retail-react-app
  add missing useToast (bad merge)
  add missing node engines
  update spike project's engines / regen v3 lockfiles
  resolve merge conflict
  merge conflict

# Conflicts:
#	packages/spike-extendend-retail-app/pwa-kit/overrides/app/components/header/index.jsx
#	packages/spike-extendend-retail-app/pwa-kit/overrides/app/pages/product-detail/index.jsx
@bfeister
fix dupe useToast
a22ef36
@bfeister
progress on making charles-solution work
74f1d24
@bfeister
initial pass at migration to resolver.getHook('resolve').tapAsync w…
8b80436 
…orking, TODO next... cleanup
@yunakim714
restore icons file and add extensible text to home
b388e56
@yunakim714
add some comments and construct hashmap in new plugin
6541b8f
@yunakim714
working glob sync lookup??
a654ef3
@yunakim714
resolve lookup when there is no extension
2cb9cce
@yunakim714
add component slot for testing
fcd183b
@vmarta vmarta marked this pull request as ready for review May 30, 2023 01:37
@vmarta vmarta requested a review from a team as a code owner May 30, 2023 01:37
@vmarta vmarta mentioned this pull request May 30, 2023
Closed
15 tasks
@bfeister bfeister enabled auto-merge (squash) May 30, 2023 23:02
@bfeister bfeister disabled auto-merge May 30, 2023 23:02
@bfeister
Copy link
Collaborator

there's a partially signed commit in history, merging

@bfeister bfeister merged commit 9baf1c8 into develop May 30, 2023
@vmarta vmarta deleted the prep-v3-preview branch May 30, 2023 23:04
bfeister added a commit that referenced this pull request Jun 1, 2023
@bfeister
Merge branch 'develop' into feature/template-extensibility-tests
7147186 
* develop:
  Prepare for v3 preview release - @W-13481576@ (#1233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfeister bfeister bfeister approved these changes

@bendvc bendvc bendvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vmarta @bfeister @bendvc @yunakim714 @vcua-mobify @alexvuong