-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Adding to Wishlist from the Product List Page #2
Merged
Merged
Changes from 29 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
e4852a8
All of my branch squashed
alexvuong 5af18a7
refactor add/remove wishlist on PLP
alexvuong 757af3b
lint
alexvuong 0c748f0
use destructing form for confirming modal
alexvuong 4eed67a
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong 91f7e79
remove rebundant code
alexvuong fda4202
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong ef5e45b
test commit
alexvuong be3ec24
PR feedback and design feedback
alexvuong 30bdf56
refactor wishlist to be aware of quantity
alexvuong 68c276a
extract messages
alexvuong 0ecae2c
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong c6d1fbd
import noop properly
alexvuong 04ae26b
refactor PLP wishlist
alexvuong a673154
remove unused method
alexvuong f37ae03
fix quantity for requests
alexvuong 62cd1a7
PR feedback and add more tests
alexvuong 6437fb3
add more unit test
alexvuong 8b77e30
translations
alexvuong b5b79b7
PR feedback
adamraya f9a020c
lint
alexvuong 920b6af
rollback some changes
alexvuong d046f95
add more tests
alexvuong cb2d449
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong 46aad23
fix test
alexvuong 9f86f1f
rollback a test
alexvuong 95d8454
compiled messages
alexvuong d301f8d
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong b77330a
resolve some merged conflict
alexvuong 576e3dc
linting
alexvuong bd66566
fix proptype
alexvuong 2eb88ed
fix stale loading state when click heart icon so fast
alexvuong 3dd7c08
Merge branch 'develop' into feature-add-to-wishlist-plp-new
alexvuong 4ffa0b0
resolve merge conflict
alexvuong 33fea95
fix tests
alexvuong bf9afe0
bump tests
alexvuong f9fb084
fix failing tests
alexvuong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small warning: react_devtools_backend.js:2842 Warning: Failed prop type: Invalid prop
isWishlistLoading
of typeboolean
supplied toProductTile
, expectedfunction
.