Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Spike/chakra v3 #2296

Draft
wants to merge 12 commits into
base: feature/extensibility-v2
Choose a base branch
from
Draft

Conversation

alexvuong
Copy link
Collaborator

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alexvuong alexvuong added the do not merge No matter what, do not merge this pr label Mar 3, 2025
@alexvuong alexvuong self-assigned this Mar 3, 2025
header: headerRecipe,
offlineBanner: offlineBannerRecipe
}
// components: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these ones commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Chakra v3 does not use component for styling components, they are now under recipes or slotRecipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge No matter what, do not merge this pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants