Node warnings with more readable Node versions #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node version range is now taken from the engines field of the package.json, which is more readable than seeing semver's representation (>=12.0.0 <13.0.0-0||>=14.0.0 <15.0.0-0).
vmarta
added
ready for review
vmarta
changed the title
adamraya
added a commit
that referenced
this pull request
Mar 22, 2022
* Fix SDK's peer dependencies versioning (#432) Previously the range was matching all possible versions. Now matching React 16 and 17 only. * Node warnings with better version formatting (#410) The node version range is now taken from the engines field of the package.json, which is more readable than seeing semver's representation (>=12.0.0 <13.0.0-0||>=14.0.0 <15.0.0-0). * [Circle CI] Add test generated project job on Windows (#412) * Update config.yml * Add `generatedSFCCProjectTestWindows` test job * Test not using gtime.js script * Increase log verbosity * Run first the CI job generated project on Windows * Use outputDir generated-project * Use execSync * Update npx pwa-kit-create-app command * Use process.argv as outputDir * Test execFileSync * Add try/catch to execSync * Show npm i logging * Show npm install logs as we do in the BFH branch * Show verdaccio logs * More logs npm install verbose * Use Node child_process & Update verdaccio config & bump version * Use verdaccio npmjs cache true * Set GENERATOR_PRESET env variable * Update create-mobify-app.js * Test using a xlarge Windows machine * Increase Verdaccio max_fails config * Remove server keepAliveTimeout * Dump all Verdaccio logs to a file for debugging * Fix smoketestscripts on Windows * Add Circle CI unit to the scripts path * Really fix smoketestscripts Circle CI job on Windows * Update config.yml * More testing smoke test script on Windows * And more testing smoke test script on Windows * smoketestscripts job working on Windows * fix typo * Clean up * More clean up * Update latest v4 verdaccio * Remove file from bad merge Co-authored-by: Vincent Marta <vmarta@salesforce.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feedback from sprint demo:
The node version range is now taken from the engines field of the package.json, which is more readable than seeing semver's representation (>=12.0.0 <13.0.0-0||>=14.0.0 <15.0.0-0).
Follow up to this merged PR #384
Types of Changes
How to Test-Drive This PR
First of all, run
npm ciat the root of the monorepo to rebuild all the packages.Then try testing the generator:
nvm use 13node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir /tmp/project... Your app may not work as expected when deployed to Managed Runtime servers which are compatible with Node ^12.0.0 || ^14.0.0Also, try running the dev server from within the 'pwa' package:
npm startAnd try running
npm ciat the root folder too with an incompatible node version.Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization