Regression: webDAV-functionality broken on Windows

[KennethRobbeFrucon]

The following line was updated in version 2.7.0, but this breaks all webDAV-functionalities on Windows:

sfcc-ci/lib/webdav.js

Line 26 in 613bf74

var endpoint = require('path').join(WEBDAV_BASE, path)

It uses path.join to join two path segments. However, path.join() is meant to interact with file paths, while this is an URI. This results in a path with backslashes on Windows, which isn't a valid URI. This can be seen by running the unit tests on Windows. All tests for lib/webdav.js fail due to these types of errors:

AssertionError: expected '\\on\\demandware.servlet\\webdav\\Sites\\cartridges\\mycode.zip' to equal '/on/demandware.servlet/webdav/Sites/cartridges/mycode.zip'

In the past, the path was just concatenated:

sfcc-ci/lib/webdav.js

Line 26 in 074cc74

var endpoint = WEBDAV_BASE + path

[KennethRobbeFrucon]

@jbachelet / @tobiaslohr Could you please look into this as you did / merged the change that caused the issue? Was this just an oversight or was there a specific reasoning behind using path.join here?

[tobiaslohr]

@KennethRobbeFrucon Agree! This is a bug and from what I can see, there was not a specific reason path.join was used instead. @jordanebachelet please correct me if I'm wrong

[tobiaslohr]

@jordanebachelet any input you can give, before we revert this particular change?

[jbachelet]

@tobiaslohr Apologize for the issue, I was only able to test it on mac, where it works fine.
We should revert this change then

[tobiaslohr]

@jbachelet Thanks. Do you have bandwidth to do this?

[zlatinz]

@jbachelet @tobiaslohr will https://nodejs.org/api/url.html#url_new_url_input_base work instead?
e.g.

var endpoint = new URL(path, WEBDAV_BASE).toString();

[tobiaslohr]

Provided a fix in #233, please review and approve