Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sandbox:get -s xxxx -O option always redirects to us01 host #250

Closed
jorgehernandezSF opened this issue Aug 30, 2021 · 1 comment · Fixed by #251
Closed

sandbox:get -s xxxx -O option always redirects to us01 host #250

jorgehernandezSF opened this issue Aug 30, 2021 · 1 comment · Fixed by #251
Assignees
@tobiaslohr
Labels
bug Something isn't working
Milestone
2.7.3

Comments

@jorgehernandezSF
Copy link

This line of code:
https://github.com/SalesforceCommerceCloud/sfcc-ci/blob/master/lib/sandbox.js#L26
is hardcoded to us01
which means that the
sfcc-ci sandbox:get -s xxxx -O command always sends you to the us01 host, which no longer exists.
@tobiaslohr
Copy link
Contributor

Thanks for raising @jorgehernandezSF! This is indeed the last leftover of us01 being the only sandbox cluster. We requested an API change of the Sandbox API. This change is for GET /sandboxes, GET /sandboxes/{id}, POST /sandboxes to return the host name of the sandbox as part of the SandboxModel, which is now being made available.

@tobiaslohr tobiaslohr self-assigned this Aug 31, 2021
@tobiaslohr tobiaslohr added this to the 2.7.3 milestone Aug 31, 2021
@tobiaslohr tobiaslohr added the bug Something isn't working label Aug 31, 2021
tobiaslohr added a commit to tobiaslohr/sfcc-ci that referenced this issue Aug 31, 2021
@tobiaslohr
SalesforceCommerceCloud#250 remove reference to hard coded us01 clust…
96d861d 
…er and use new hostName property of SandboxModel instead
@tobiaslohr tobiaslohr mentioned this issue Aug 31, 2021
Merged
tobiaslohr added a commit that referenced this issue Aug 31, 2021
@tobiaslohr
Merge pull request #251 from tobiaslohr/us01-host-fix
88f6ec1 
#250 remove reference to hard coded us01 cluster and use new hostName…
tobiaslohr added a commit to tobiaslohr/sfcc-ci that referenced this issue Aug 31, 2021
@tobiaslohr
SalesforceCommerceCloud#250 remove obsolete constant
93f1564
tobiaslohr added a commit that referenced this issue Aug 31, 2021
@tobiaslohr
Merge pull request #252 from tobiaslohr/us01-host-fix
1a146a0 
#250 remove obsolete constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiaslohr tobiaslohr

Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.3
Development

Successfully merging a pull request may close this issue.

#250 remove reference to hard coded us01 cluster and use new hostName… tobiaslohr/sfcc-ci
2 participants
@tobiaslohr @jorgehernandezSF