Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.13 #92

Merged
merged 7 commits into from
Oct 27, 2024
Merged

Update to Python 3.13 #92

merged 7 commits into from
Oct 27, 2024

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Sep 22, 2024

  • Add conda-forge/label/python_rc channel to test environment description
  • Add Python 3.13.0rc2 to GHA pytest-with-coverage workflow python-version matrix so that we can use the workflow to test whether all the packages NEMO-Cmd depends on have been updated to support Python 3.13.

After Python 3.13 release on 7-Oct-2024, and availability of Python 3.13 in conda-forge channel:

  • Drop conda-forge/label/python_rc channel from test environment description
  • Change GHA pytest-with-coverage workflow python-version matrix to test Python 3.13
  • Change conda environment descriptions to use Python 3.13
    • environment-dev.yaml
    • environment-hpc.yaml
    • environment-rtd.yaml
  • Update Sphinx and optional dependencies version pins
  • Change sphinx-linkcheck workflow to Python 3.13
  • Change pkg dev doc & README to Python 3.13 for package development

Added Python 3.13.0rc2 to the pytest-with-coverage workflow python-version
matrix to test compatibility with the latest release candidate. Also added
'conda-forge/label/python_rc' channel to the test environment configuration
to enable installation of the release candidate.
@douglatornell douglatornell added the maintenance Package or repo maintenance label Sep 22, 2024
@douglatornell douglatornell added this to the v23.2 milestone Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.60%. Comparing base (b793fbc) to head (5aee128).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #92    +/-   ##
========================================
  Coverage   60.60%   60.60%            
========================================
  Files          16       16            
  Lines        2330     2330            
  Branches      401      126   -275     
========================================
  Hits         1412     1412            
  Misses        918      918            
Flag Coverage Δ
unittests 60.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Changed from Python 3.13.0rc2 to 3.13 in the pytest-with-coverage workflow
python-version matrix to test compatibility with the final release. Also dropped
the 'conda-forge/label/python_rc' channel from the test environment configuration
because it is no longer needed.
Upgraded the OS to Ubuntu 24.04 and updated the Python toolchain to
mambaforge-23.11 in the .readthedocs.yaml file. This ensures compatibility with
the latest environment settings.
Upgraded Python from version 3.12 to 3.13 across various YAML files. This
includes updates to development, RTD, and HPC environments, as well as GHA
sphinx-linkcheck workflow.
Updated Sphinx and optional dependencies packages pinned versions in
`environment-dev.yaml`, `environment-test.yaml`, and `environment-rtd.yaml` to
get functional Python 3.13 environment.
Upgraded the required Python version to 3.13 in `pyproject.toml` and updated
related documentation and links to reflect this change.
Reverted the required Python version from 3.13 to 3.11 in pyproject.toml
because I made a mistake. It has to be the oldest version that the package
supports, and we're leaving that at 3.11 due to several group members' envs
on graham.
@douglatornell douglatornell marked this pull request as draft October 18, 2024 21:50
@douglatornell
Copy link
Member Author

Wait to merge until the SalishSeaCmd package has been updated and the two have been tested in a Python 3.13 env on graham.

@douglatornell douglatornell marked this pull request as ready for review October 27, 2024 19:18
@douglatornell
Copy link
Member Author

Successfully tested in conjunction with Python 3.13 update of SalishSeaCmd package in a new Python 3.13 env on graham.

@douglatornell douglatornell merged commit 6434f0f into main Oct 27, 2024
10 checks passed
@douglatornell douglatornell deleted the py313 branch October 27, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package or repo maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant