Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use androidx #1

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

anees17861
Copy link

A change was made to use android support. All modern projects should be migrated to androidx

@fabiendem
Copy link

Damn I was looking at the exact same issue at the same time.
Thanks for the fix!!
Hopefully it can be merged soon 🤞

@fabiendem
Copy link

Hi @manualexSP, any chance we can merge this PR please?

@manualexSP
Copy link

@fabiendem & @anees17861 Hey guys thank you for doing this. I will talk with my team and we will do some tests with this change to see how it works on our end and we will come back to you with an update :D

@fabiendem
Copy link

fabiendem commented Nov 17, 2022

It should fix the following warnings while running jetify.

Jetifier found xxxx file(s) to forward-jetify. Using 10 workers...
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-nordic-dfu/android/src/main/java/com/pilloxa/dfu/NotificationActivity.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-nordic-dfu/android/src/main/java/com/pilloxa/dfu/RNNordicDfuModule.java

@manualexSP manualexSP merged commit 9ca23e4 into Salt-PepperEngineering:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants