Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names that use prohibited characters fail to parse #25

Closed
Abbondanzo opened this issue Jun 7, 2019 · 0 comments · Fixed by #28
Closed

Names that use prohibited characters fail to parse #25

Abbondanzo opened this issue Jun 7, 2019 · 0 comments · Fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@Abbondanzo
Copy link
Member

Issue

Example replay: https://calculated.gg/replays/9944A36A11E987D3E286C1B524E68ECC

Three.js has a few prohibited characters (outlined here) which can cause parsing failures since we rely on the name of the user in the replay to build objects

Solution

Hash names using only approved characters ([A-z0-9]) to avoid any character collisions

@Abbondanzo Abbondanzo added the bug Something isn't working label Jun 7, 2019
@Abbondanzo Abbondanzo self-assigned this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant