Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issues and bugs #28

Merged
merged 12 commits into from
Jun 10, 2019
Merged

Fix performance issues and bugs #28

merged 12 commits into from
Jun 10, 2019

Conversation

Abbondanzo
Copy link
Member

@Abbondanzo Abbondanzo commented Jun 10, 2019

This PR adds a number of fixes, including:

In addition, the following new features were added:

  • GameManagerLoader wrapper that, given GameBuilderOptions, will handle asynchronous loading of all models and will display loading percentages.
    • Previously, we merged the responsibility of loading replay data/metadata and building the scene into one single async call. However, this is misleading since the user assumes these load times are responsible for the API call alone. Showing loading progress provides a better UX
  • Separation of Application and replay viewer in the example project. This lets us test the performance of the replay viewer in a more realistic environment, allowing us to check that certain features like in-memory model storage work as intended. This is especially important for letting us simulate CPU latency in the future

@Abbondanzo Abbondanzo merged commit 8f196fc into master Jun 10, 2019
@Abbondanzo Abbondanzo deleted the pa-perf-cleanup branch June 10, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants