Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compact player controls and support for custom wrapped components #57

Merged
merged 15 commits into from
Oct 7, 2019

Conversation

Abbondanzo
Copy link
Member

@Abbondanzo Abbondanzo commented Oct 6, 2019

Adds a few new features

  • Adds compact controls that provide the same functionality as the standard set of controls provide.
  • New compact view tab to testing page
  • Optional autoplay prop added to replay viewer that will start or stop the clock on mount
  • Caches requests for position data to prevent duplicate requests

Fixes a few bugs as well:

  • Fixes a bug where the objects that spawn in the scene don't take their correct positions
  • Fixes a bug where the "play" button doesn't match the initial state of the viewer

@dtracers
Copy link
Member

dtracers commented Oct 6, 2019

Cool looks good!
Am slightly confused on how custom wrapped components work but looks great!

@Abbondanzo Abbondanzo merged commit ae660b9 into master Oct 7, 2019
@Abbondanzo Abbondanzo deleted the pa-compact branch October 7, 2019 01:40
@Abbondanzo
Copy link
Member Author

@dtracers

Am slightly confused on how custom wrapped components work but looks great!

Which wrapped components?

@dtracers
Copy link
Member

dtracers commented Oct 7, 2019

I am taking this from your title

and support for custom wrapped components

@Abbondanzo
Copy link
Member Author

Abbondanzo commented Oct 7, 2019

Ah. The ReplayViewer can wrap children that you want to render inside of the fullscreen view. So you can do this now

<ReplayViewer>
  <MyCustomComponent />
</ReplayViewer>

It lets us maintain these player controls (the slider, play/pause, etc.) inside both views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants