Use core http(s) Agent instead of agentkeepalive module #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason was that there was no keep alive agent for https when I first wrote this module. Thanks for the PR! |
|
Makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using this module to send requests against a pretty slow interface. We were seeing sockets closed for no apparent reason at the 1 minute mark, resulting in ECONNRESET errors. I eventually traced the problem to the agentkeepalive module. Using the core http Agent instead resolved the issue for me.
I realize there may be reasons beyond what I've noticed that agentkeepalive is used here, but for my use case the core module makes more sense, so I thought I would propose this. We are running iojs 2.x.x, but I believe these changes should be acceptable for Node as well.