Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Suggestion for Faster Runtime #7

Closed
rohhenry opened this issue Jul 31, 2020 · 8 comments
Closed

Possible Suggestion for Faster Runtime #7

rohhenry opened this issue Jul 31, 2020 · 8 comments

Comments

@rohhenry
Copy link

rohhenry commented Jul 31, 2020

Anyone wanna change it so that it only downloads new data saving the old yahoo finance data? What I mean is storing the mean volume, number of data points, as well as the variance and just updating it depending on the day? This will probably decrease runtime to less than a few seconds. I can try to implement it too if there's enough interest.

UPDATE: I wrote a proof of concept it runs faster amortized. Enough changes needed to be made so I rewrote the main script. Its on my github if anyone is curious. Just a heads up though its very scuffed. File storage is in json so if anyone can fork my code to turn it into csv would be perfect. Runtime is still largely gated by yfinance download speed.

@jsncmgs1
Copy link

I don't know python but I've been trying to get a threadpool working with the progress bar too but this sounds good

@ArrrNeo
Copy link

ArrrNeo commented Jul 31, 2020

even i was thinking in same line. i was thinking to store data as dictionary with date as key for my testing. however If someone has already stated working on it and/or have better suggestions we can work together. though seems like simple enough job. i might post something by tomorrow if i do manage to complete it by then.

@ApurvShah007
Copy link

How about you add specific functionality where users can only watch a certain stock for such anomalies.

@Connor9994
Copy link

How about you add specific functionality where users can only watch a certain stock for such anomalies.

The point of a script like this would be to find random stocks that have surged based on no publicly-available news. It doesn't really make sense to just watch a particular stock in this context.

@ApurvShah007
Copy link

@Connor9994 Yeah that makes sense. My bad.

@Connor9994
Copy link

Connor9994 commented Jul 31, 2020

@Connor9994 Yeah that makes sense. My bad.

I did see a suggestion to omit certain tickers which as a denylist would be a lot harder to setup but would certainly increase the speed (for instance nobody is gunna pump and dump Amazon stock lol)

@ApurvShah007
Copy link

@Connor9994 I see the point with that but I do not think we should skip big stocks either. As the upcoming 4 to 1 split for AAPL will probably lead to such anomaly and hence skipping the major stocks can be pretty bad.

@rohhenry
Copy link
Author

rohhenry commented Aug 3, 2020

Just found out there's this repo's creator also made website that displays the information. So I'm closing this issue as it's not very relevant anymore.

@rohhenry rohhenry closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants