Add ability to run this project in Docker #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just considering doing the same thing! |
BeauBouchard
approved these changes
Jul 31, 2020
README.md
Outdated
| ## How to run | ||
| Build docker image by running | ||
| <pre> | ||
| docker build docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 . |
There was a problem hiding this comment.
Suggested change
| docker build docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 . | |
| docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 . |
|
This isn’t working for me
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Beau Bouchard<mailto:notifications@github.com>
Sent: Thursday, July 30, 2020 7:37 PM
To: SamPom100/UnusualVolumeDetector<mailto:UnusualVolumeDetector@noreply.github.com>
Cc: Subscribed<mailto:subscribed@noreply.github.com>
Subject: Re: [SamPom100/UnusualVolumeDetector] Add ability to run this project in Docker (#9)
@BeauBouchard commented on this pull request.
In README.md<#9 (comment)>:
…--run the market_scanner.py and it will print out results into the terminal
--you can also graph any ticker's volume in grapher.py
+3) Open project in your IDE and install all required dependancies by typing pip install -r requirements.txt into the IDE's terminal. You can get to the the terminal on VSC by pressing CMD and ` at the same time.
+
+## How to run
+Build docker image by running
+<pre>
+docker build docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 .
⬇️ Suggested change
-docker build docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 .
+docker build --tag NAME:VERSION . ie docker build --tag wsb:1.0 .
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#9 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5FYCU4NTOCT57M57OBQ4LR6IU6HANCNFSM4PPAEFMA>.
|
README.md
Outdated
| 3) Open project in your IDE and install all required dependancies by typing pip install -r requirements.txt into the IDE's terminal. You can get to the the terminal on VSC by pressing CMD and ` at the same time. | ||
|
|
||
| ## How to run | ||
| Build docker image by running |
There was a problem hiding this comment.
you may want to explain how to install docker, or even link to the install page here:
https://docs.docker.com/get-docker/
There was a problem hiding this comment.
That's already noted in the requirements section, line #7 of the readme.
Though it's probably worth being explicit that you need to run these docker commands in the same directory as the Dockerfile.
There was a problem hiding this comment.
@BeauBouchard See line 7 and @RKosow it's very obvious but also a good idea, adding that now
Change time output to minutes instead of seconds Add ability to print all results together an the end Output anomalous tickers to a results.txt file
opens anomalous tickers in Robinhood in a new browser window
Creates graphs for all tickers in results.txt Allows option for single ticker or tickers of your choice
Example results.txt file
change line numbers for controlling the script
Add/update descriptions grapher.py and openRobinhood.py
Fix formatting error
Provides option to save graphs to the figures directory or to print them to screen
Create figures dir if it doesn't exist
remove previous addition of printing anomalous results together at the end
Parallelization
Revert "Parallelization"
Add various functionality
Revert "Add various functionality "
|
@adeiva Can you please provide more information what exactly is not working for you. |
|
The market scanner runs but it just tells me the amount of time it takes to run.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Alikhan Uzakov<mailto:notifications@github.com>
Sent: Friday, July 31, 2020 10:52 AM
To: SamPom100/UnusualVolumeDetector<mailto:UnusualVolumeDetector@noreply.github.com>
Cc: adeiva<mailto:vdeiva@hotmail.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [SamPom100/UnusualVolumeDetector] Add ability to run this project in Docker (#9)
@adeiva<https://github.com/adeiva> Can you please provide more information what exactly is not working for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5FYCTU4AF2ON5EE5KCKGLR6MAEPANCNFSM4PPAEFMA>.
|
|
@adeiva I just checked again and it all works, have you waited when running the script? It does take a while |
added 2 commits
July 31, 2020 19:31
|
@SamPom100 I believe its ready for review |
|
Yes I’ve waited while running the script and it’s now working.
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
From: Alikhan Uzakov<mailto:notifications@github.com>
Sent: Friday, July 31, 2020 11:31 AM
To: SamPom100/UnusualVolumeDetector<mailto:UnusualVolumeDetector@noreply.github.com>
Cc: adeiva<mailto:vdeiva@hotmail.com>; Mention<mailto:mention@noreply.github.com>
Subject: Re: [SamPom100/UnusualVolumeDetector] Add ability to run this project in Docker (#9)
@adeiva<https://github.com/adeiva> I just checked again and it all works, have you waited when running the script? It does take a while
[image]<https://user-images.githubusercontent.com/11824569/89065850-584f3e00-d364-11ea-80d0-93ff482a4384.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#9 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD5FYCRNENIL23H7MCRRKLTR6MEYNANCNFSM4PPAEFMA>.
|
gaby
reviewed
Aug 5, 2020
| @@ -0,0 +1,17 @@ | |||
| FROM python:3 | |||
There was a problem hiding this comment.
Consider using smaller image, there's no need to have all of python to run this.
python:3-slim-buster is around 48MB compressed.
python:3 is around 320MB compressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it easier to run this project, by running it in Docker and not having to install all the Python requirements. As you see from Reddit WSB comments many people can't run this project easily.
Note
This doesn't address PIP8 issues