Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deploying js/css #657

Merged
merged 5 commits into from
Jul 25, 2020
Merged

Simplify deploying js/css #657

merged 5 commits into from
Jul 25, 2020

Conversation

stefanloerwald
Copy link
Contributor

This change adds a powershell script and a Dockerfile to help deploy js/css static assets on a machine without npm.

How it works:

  • when the docker container is built, it creates the up-to-date resources. Changes to any file will trigger a rebuild.
  • the resources are then essentially just copied out of the image, overwriting the files in the dist folder.

The main advantage of this approach is that the deploy step doesn't require setting up npm anymore (and one doesn't have to worry about environments, as it's a fresh environment). Of course that's traded against the requirement of docker + powershell (a similar bash script would be very easy to add, if some developers are unix-based).

@lindespang
Copy link
Collaborator

Cool addition, do you mind persisting this "How-to" text somewhere? Maybe in the wiki where the NPM info is?

Also please change base to develop branch! (On mobile cant see the control to change it myself)

@stefanloerwald stefanloerwald changed the base branch from master to develop July 25, 2020 14:40
@stefanloerwald
Copy link
Contributor Author

Updated. Thanks for the quick response, @lindespang

@lindespang lindespang merged commit 1da0ddd into SamProf:develop Jul 25, 2020
@lindespang
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants