Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #117

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix tests #117

merged 1 commit into from
Jun 17, 2024

Conversation

fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Jun 17, 2024

Fixes #115.

Tests are currently failing (see #116, for example), suggesting that there are one less object allocated than we expect, because of some changes in minitest recently.

Previously, this line

MiniTest::Reporter.new
allocated 2 objects (array via *args and a Thread::Mutex instance):
minitest/minitest@5f5c211#diff-b43f1192f616004aa819abdb67ebe90528572c49ec805b9ad66ce45e1afce97bL622
https://github.com/ruby/mutex_m/blob/86ee14345740636a909b54f089f7eb0d51ea134f/lib/mutex_m.rb#L116-L119

But after the changes, only the mutex now: minitest/minitest@5f5c211#diff-b43f1192f616004aa819abdb67ebe90528572c49ec805b9ad66ce45e1afce97bR621-R623

@SamSaffron SamSaffron merged commit 846e6b5 into SamSaffron:master Jun 17, 2024
5 checks passed
@SamSaffron
Copy link
Owner

thanks @fatkodima !

@fatkodima fatkodima deleted the fix-tests branch June 17, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with tests on ruby 3.2
2 participants