Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Ukrainian translation #83

Open
0x9fff00 opened this issue Aug 28, 2019 · 8 comments
Open

Duplicate Ukrainian translation #83

0x9fff00 opened this issue Aug 28, 2019 · 8 comments

Comments

@0x9fff00
Copy link

There are currently two Ukrainian translations in this project:

ua-UA.lproj should either be removed or merged into uk-UA.lproj.

@badger-ua
Copy link
Contributor

badger-ua commented Aug 28, 2019

Yeah, that’s true, ua-UA is incorrect.
PS: I’m opened for improvements if I did translate something incorrectly.

@sage444
Copy link
Contributor

sage444 commented Aug 28, 2019 via email

@Samgisaninja
Copy link
Owner

so remove ua-UA or wait for sage to merge? or both?

@sage444
Copy link
Contributor

sage444 commented Aug 29, 2019

@Samgisaninja I finished merge and submitted PR #85 (where ua-UA is removed)
We still in discussion about right translation of some words but in general translation is ready to use. Can you confirm @YYesi ?

@badger-ua
Copy link
Contributor

@sage444 yeah, it's definitely better now

@Samgisaninja
Copy link
Owner

Y'all good to merge or want more time?

@sage444
Copy link
Contributor

sage444 commented Aug 29, 2019

I vote for merge now.

@badger-ua
Copy link
Contributor

I vote for merge now.

Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants