Add support for environment variables #110
Conversation
rradczewski
force-pushed
the
feature/add-envvars
branch
from
2b6235f to
64b56be
Compare
rradczewski
force-pushed
the
feature/add-envvars
branch
from
f66f8cf to
6e6c62b
Compare
| @@ -0,0 +1 @@ | |||
| ARGV.each { |arg| puts ENV[arg] } | |||
There was a problem hiding this comment.
I've added this to generalize retrieving env variables between operating systems. Alternatively, we could have each of the tests echo both, e.g. echo $TEST_ENV %TEST_ENV% and assert on either of them being substituted. LMK
There was a problem hiding this comment.
I think this is solid. It might be worth adding tests for Windows in the future if we find it to be strange in some way but I don't expect it's necessary.
rradczewski
force-pushed
the
feature/add-envvars
branch
from
0217193 to
312b0fa
Compare
rradczewski
force-pushed
the
feature/add-envvars
branch
from
312b0fa to
819dfbf
Compare
| @@ -0,0 +1 @@ | |||
| ARGV.each { |arg| puts ENV[arg] } | |||
There was a problem hiding this comment.
I think this is solid. It might be worth adding tests for Windows in the future if we find it to be strange in some way but I don't expect it's necessary.
|
@rradczewski, this needs a bit of explanation in the README, but otherwise I think it's fine. Would you like to do it or shall I? |
I'll do it! |
rradczewski
force-pushed
the
feature/add-envvars
branch
from
1cc5200 to
040a25e
Compare
No description provided.