- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
Create Serialization Helper
Merge blazpezdir changes locally
Support multiple db connection
Additional comment for testing. Since sqlite is used for testing, it is not that straight forward to implement tests for mysql/pgsql. That would also require additional work for both local development and github actions. However, if adding tests is necessary I can work on them in the scope of this PR or in some other PR. |
Many thanks for this PR I will have a review now. If you know how to build a testing matrix with SQLite, MySQL and Postgres that would be fantastic. Might that be something you could add to this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this
Even though this is not directly related to this PR, I see this will eventually be done by workflow automation, so it is not really wrong thing to do.
Added tests, as requested. Additionally, I ran pint on whole project (not just on updated files) and fixed code style per your suggestion. There are 2 things you should be aware of.
|
Hey @Sammyjo20. I am just wondering if there is a plan to release this any time soon? If not, I will need to unblock my projects by using my own fork. No problem at all if there is no plan to release it. Thank you! |
Hey @ksimenic I am hoping to release this at the weekend if this works for you? |
@Sammyjo20 works for me. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this 💪
Thank you @ksimenic for your help on this! |
Hey @Sammyjo20. Thank you for releasing this! Just wondering why you dropped support for Laravel 8.x? |
Hey @ksimenic I've dropped support for Laravel 8 because it's no longer getting any security updates or officially supported. |
This PR merges 2 existing PRs: #60 and #63 and potentially solves #61
Additionally, both PRs are standardised (pint) and upgraded with following changes:
DB::connection instanceof
check to separate function and take db_connection configuration var (from 60) into account