[luci/import] Revise ImportEx

[seanshpark]

This will revise ImportEx ctro with graph builder source and new importModule method.

[seanshpark]

• for [Compiler] flatbuffer verify for size > 2GB #13674
• from DRAFT CFe to support huge 2G model #13615

this change is necessary to make embedded-import-value-test module work.
embedded-import-value-test is the only client that will use this methods.

• this will make [embedded-import-value-test] Revise to use ImportEx #13791 pass

[shs-park]

LGTM!
=)

[seanshpark]

Um?

[2024-08-30T00:55:52.100Z] [  489s] [ 68%] Built target onert_backend_cl_common
[2024-08-30T00:55:52.100Z] [  490s] [ 68%] Building CXX object runtime/onert/odc/CMakeFiles/onert_odc.dir/Embedder.cc.o
[2024-08-30T00:55:52.357Z] [  490s] In file included from /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/build/overlay/include/luci/Import/GraphBuilderContext.h:20,
[2024-08-30T00:55:52.357Z] [  490s]                  from /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/build/overlay/include/luci/Import/GraphBuilderBase.h:20,
[2024-08-30T00:55:52.357Z] [  490s]                  from /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/build/overlay/include/luci/Import/GraphBuilderRegistry.h:20,
[2024-08-30T00:55:52.357Z] [  490s]                  from /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/build/overlay/include/luci/ImporterEx.h:22,
[2024-08-30T00:55:52.357Z] [  490s]                  from /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/runtime/onert/odc/Embedder.cc:22:
[2024-08-30T00:55:52.357Z] [  490s] /home/abuild/rpmbuild/BUILD/nnfw-1.29.0/build/overlay/include/luci/Import/CircleReader.h:20:10: fatal error: mio/circle/schema_generated.h: No such file or directory
[2024-08-30T00:55:52.357Z] [  490s]    20 | #include <mio/circle/schema_generated.h>
[2024-08-30T00:55:52.357Z] [  490s]       |          ^~~~~~~~~~~~~~~

[seanshpark]

@hseok-oh do you know why this happens and how to fix this?

[seanshpark]

@hseok-oh , #include <luci/ImporterEx.h> in Embedder.cc seems unnecessary header.
Can you check it?

[seanshpark]

@shs-park , PTAL again,
I've modified a little bit to avoid tizen-gbs build failure.
I'll update this change after onert Embedder.cc removes include to ImporterEx.h.

[shs-park]

👍

[hseok-oh]

Embedder.cc is not using ImporterEx.h, but runtime/onert/odc/Quantizer.cc is using ImporterEx.h to export quantized circle file. So this issue still remains.

In fact, runtime is already using workaround to avoid build fail by referencing not installed header from luci public header.

ONE/Makefile.template

Lines 170 to 172 in 7aee01c

	@cp compiler/angkor/include/nncc/core/ADT/tensor/Index.h ${OVERLAY_FOLDER}/include/nncc/core/ADT/tensor
	@cp compiler/oops/include/oops/InternalExn.h ${OVERLAY_FOLDER}/include/oops
	@cp compiler/luci/lang/include/luci/IR/CircleNodes.lst ${OVERLAY_FOLDER}/include/luci/IR

ONE/packaging/nnfw.spec

Lines 205 to 207 in 7aee01c

	cp compiler/angkor/include/nncc/core/ADT/tensor/Index.h %{overlay_path}/include/nncc/core/ADT/tensor
	cp compiler/oops/include/oops/InternalExn.h %{overlay_path}/include/oops
	cp compiler/luci/lang/include/luci/IR/CircleNodes.lst %{overlay_path}/include/luci/IR

Maybe we can avoid this issue by using same workaround.
Anyway, I inform that luci public headers have some dependency issue. It may be passed if we build compiler modules at once, but developer may meet same issue with this when developer tries to include installed luci headers.

[seanshpark]

To use luci, onert must include dependent modules for building.
Just copy header files that looks like using doesn't seem to be a good way.

[hseok-oh]

To use luci, onert must include dependent modules for building. Just copy header files that looks like using doesn't seem to be a good way.

Including luci and dependent module build in runtime cmake script is not easy, so I divided build process on makefile (and tizen spec file) level for luci and runtime. So runtime uses installed compiler libraries and headers.

On the other hand, areser is included in runtime cmake script because arser is header-only.

ONE/infra/nnfw/CMakeLists.txt

Lines 119 to 124 in 7aee01c

	# Add arser for test driver
	# TODO: Better way to handle this
	if(ENABLE_TEST)
	add_library(arser INTERFACE)
	target_include_directories(arser INTERFACE ${NNAS_PROJECT_SOURCE_DIR}/compiler/arser/include/)
	endif(ENABLE_TEST)