[nnpackage] Update circle schema #13930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New types are renamed to |
hseok-oh
force-pushed
the
qx_y_type_circle
branch
from
4f10d75 to
d882cf3
Compare
hseok-oh
changed the title
|
@SlavikMIPT Please check weight compression |
|
@seanshpark @glistening PTAL |
seanshpark
reviewed
Sep 6, 2024
nnpackage/schema/circle_schema.fbs
Outdated
| @@ -221,6 +230,12 @@ table VariantSubType { | |||
| has_rank: bool = false; | |||
| } | |||
|
|
|||
| enum CompressionType : byte { | |||
| NONE = 0, | |||
| //Huffman encoding only | |||
There was a problem hiding this comment.
Suggested change
| //Huffman encoding only | |
| // Huffman encoding only |
There was a problem hiding this comment.
this comment seems unnecessary as it explains there is only Huffman ...
There was a problem hiding this comment.
I'll remove this comment
This commit updates circle schema to 0.9
- Introduce GGML_Q{X}_{Y} types for ggml block quantization
- Introduce weight compression type and option
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
hseok-oh
force-pushed
the
qx_y_type_circle
branch
from
d882cf3 to
c7fd4db
Compare
SlavikMIPT
approved these changes
Sep 7, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates circle schema to 0.9
Related issue: #13743 #13521