Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Update nnfw_load_model_from_file comment and parameter #14478

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit updates the comment of nnfw_load_model_from_file and parameter name.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com

This commit updates the comment of nnfw_load_model_from_file and parameter name.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Dec 19, 2024
@hseok-oh hseok-oh requested a review from glistening December 19, 2024 01:43
Comment on lines -78 to -85
/*
* Load model from nnpackage file or directory
*
* @param session nnfw_session loading the given file/dir
* @param file_path path to the model file or nnpackage directory to be loaded
*
* @return NNFW_STATUS_NO_ERROR if successful
*/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it is duplication with header.

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 3099167 into Samsung:master Dec 19, 2024
9 checks passed
@hseok-oh hseok-oh deleted the update_loader_api_comment branch December 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants