[luci] Support Transpose in InsertQuantizeOpOnDTypeMismatch #14488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports Transpose Op in InsertQuantizeOpOnDTypeMismatch. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <hj1.jeong@samsung.com>
|
To reviewers: This PR is for Llama3.2 quantization. |
mhs4670go
reviewed
Dec 22, 2024
Comment on lines
+146
to
+150
| if (not is_quantized(input)) | ||
| return; | ||
|
|
||
| if (not is_quantized(node)) | ||
| return; |
There was a problem hiding this comment.
I think these lines follows other implementations. But, just curiosity, can this case really happen?
There was a problem hiding this comment.
I expect that it should not happen for our target model, but I'm not 100% sure. These branches are useful because I don't have to consider whether this case will never happen or not. We can just apply this pass to safe cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports Transpose Op in InsertQuantizeOpOnDTypeMismatch.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong hj1.jeong@samsung.com