Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Add TensorFlowLiteRecipes for broadcast Add #14570

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jan 21, 2025

Let's add 3 more recipes for broadcast Add.

ONE-DCO-Signed-off-by: Dayoung Lee dayoung.lee@samsung.com


From #14564
For #14552

Let's add 3 more recipes for broadcast Add.

ONE-DCO-Signed-off-by: Dayoung Lee <dayoung.lee@samsung.com>
operand {
name: "ifm2"
type: FLOAT32
shape { dim: 1 dim: 2 dim: 2 dim: 3 }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add_003-006 includes examples broadcasting of last dimension.

Here, I add first-mid dimension broadcasting examples.

Add_007: broadcast to dim 0

operand {
name: "ifm2"
type: FLOAT32
shape { dim: 1 dim: 2 dim: 3 }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadcast to dim 0, with rank 3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, in ONE/compiler/luci and related, rank is used for number of dimensions,
so here IIUC rank 3 can be expressed as size 3

operand {
name: "ifm2"
type: FLOAT32
shape { dim: 4 dim: 1 dim: 3 }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadcast to dim 1, with rank 3

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit c7b530c into Samsung:master Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants