[luci-interpreter] Add StaticMemoryManager #7735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalyshevArtem
force-pushed
the
staticManager
branch
from
aafd9e5 to
ce5c21c
Compare
binarman
reviewed
Sep 24, 2021
compiler/luci-interpreter/include/luci_interpreter/StaticMemoryManager.h
Outdated
Show resolved
Hide resolved
compiler/luci-interpreter/include/luci_interpreter/StaticMemoryManager.h
Outdated
Show resolved
Hide resolved
BalyshevArtem
force-pushed
the
staticManager
branch
from
ce5c21c to
cdb59f4
Compare
m-bronnikov
previously approved these changes
Sep 27, 2021
| public: | ||
| StaticMemoryManager() = delete; | ||
|
|
||
| explicit StaticMemoryManager(uint8_t *buffer_ptr) { _buffer_ptr = buffer_ptr; } |
There was a problem hiding this comment.
(optional)
Suggested change
| explicit StaticMemoryManager(uint8_t *buffer_ptr) { _buffer_ptr = buffer_ptr; } | |
| explicit StaticMemoryManager(uint8_t *buffer_ptr) : _buffer_ptr(buffer_ptr) { /* Do nothing */ } |
There was a problem hiding this comment.
Need to run nnas format, I think this line will be wrapped
There was a problem hiding this comment.
Need to run
nnas format, I think this line will be wrapped
@binarman @m-bronnikov
I did nnas format and in result it divided the figured brackets on rows
m-bronnikov
reviewed
Sep 27, 2021
m-bronnikov
reviewed
Sep 27, 2021
compiler/luci-interpreter/include/luci_interpreter/core/Tensor.h
Outdated
Show resolved
Hide resolved
added 2 commits
September 28, 2021 12:03
This commit adds static memory manager. ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@partner.samsung.com
This commit deletes destructor and fixes comment in StaticMemoryManager ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@partner.samsung.com
BalyshevArtem
dismissed stale reviews from m-bronnikov and binarman
via
2f9ecfd
BalyshevArtem
force-pushed
the
staticManager
branch
from
cdb59f4 to
2f9ecfd
Compare
|
format-checker failed, please fix format by following commands (need clang-format 3.9):
Or apply format.patch using following commands:
Or there may be files having CRLF as newline. Please use LF. To re-run this test, leave a comment |
This commit fixes constructor and remove redundant actions in allocate method. ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@partner.samsung.com Signed-off-by: Artem Balyshev <a.balyshev@partner.samsung.com>
BalyshevArtem
force-pushed
the
staticManager
branch
from
2f9ecfd to
e191609
Compare
binarman
previously approved these changes
Sep 28, 2021
| public: | ||
| StaticMemoryManager() = delete; | ||
|
|
||
| explicit StaticMemoryManager(uint8_t *buffer_ptr) { _buffer_ptr = buffer_ptr; } |
There was a problem hiding this comment.
Need to run nnas format, I think this line will be wrapped
m-bronnikov
approved these changes
Sep 28, 2021
| StaticMemoryManager() = delete; | ||
|
|
||
| explicit StaticMemoryManager(uint8_t *buffer_ptr) : _buffer_ptr(buffer_ptr) | ||
| { /* Do nothing */ |
There was a problem hiding this comment.
Looks strange, but Im okay with it =)
binarman
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds static memory manager to luci-interpreter.
issue: #7522
draft: #7573
ONE-DCO-1.0-Signed-off-by: Artem Balyshev a.balyshev@partner.samsung.com