[Map]Adds GoogleMapView #183

jkpu · 2019-04-11T08:36:03Z

Description of Change

This PR adds GoogleMaview for supporting google JavaScript Map.

GoogleMapview (roadmap, satellite, hybrid, terrain)
add marker on GoogleMapview

Bugs Fixed

fixes MapView for supporting google map API #169

API Changes

Added:

Add GoogleMapView
Add GoogleMapOption
Add Marker

Behavioral Changes

added new control

rookiejava · 2019-04-15T04:35:46Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/IndexPageRenderer.cs

@@ -157,7 +157,7 @@ private void OnInnerLayoutUpdate()

        private void OnPageScrolled(object sender, EventArgs e)
        {
-            Console.WriteLine($"OnPageScrolled()  _pageIndex:{_pageIndex}, HorizontalPageIndex:{_scroller.HorizontalPageIndex}, _isUpdateCarousel:{_isUpdateCarousel}");
+            Log.Debug(FormsCircularUI.Tag, $"OnPageScrolled()  _pageIndex:{_pageIndex}, HorizontalPageIndex:{_scroller.HorizontalPageIndex}, _isUpdateCarousel:{_isUpdateCarousel}");


How do you separate log-related changes that are not related to the Map into separate PRs?

rookiejava · 2019-04-15T04:50:37Z

src/Tizen.Wearable.CircularUI.Forms/Geocoding.cs

+    /// Geocoding is the process of converting addresses into geographic coordinates.
+    /// Reverse geocoding is the process of converting geographic coordinates into a human-readable address.
+    /// </summary>
+    public class Geocoding


I'm not sure if we need to provide GoogleMap based Geocoding API at the moment. For me, I just needed a View to show Google Maps for circualr UI. Are there any special reasons to include this?

Naming is a bit ambiguous. It is tightly coupled with GoogleMap (not the general one). So, for me, Geocoding sounds so common.

remove Geocoding API

rookiejava · 2019-04-15T04:55:25Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/Maps.cs

+
+namespace Tizen.Wearable.CircularUI.Forms.Renderer
+{
+    public static class Maps


GoogleMaps sounds better for the sake of clararity.

rookiejava · 2019-04-15T04:59:53Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/Maps.cs

+        /// <summary>
+        /// Initialize Map service with authentication key value.
+        /// </summary>
+        public static void Init(string apiKey, GoogleSignedType signType = GoogleSignedType.ApiKey, string channel = null, string privateKey = null)


Considering the same assembly for CircularUI, additional Maps.Init() doesn't look good. We can overloading the FormsCircularUI.Init for GoogleMaps.

rookiejava · 2019-04-15T05:00:53Z

src/Tizen.Wearable.CircularUI.Forms/MapView.cs

+
+        public MapView()
+        {
+            var option = new MapOption(new Position(41.890202, 12.492049));


where these values come from?

xamarin.forms.map default value.

rookiejava · 2019-04-15T05:17:12Z

src/Tizen.Wearable.CircularUI.Forms/MapView.cs

+    /// <summary>
+    /// The MapView class is used to display a map on the screen.
+    /// </summary>
+    public class MapView : View


What are we doing now, general map view that is independent of map provider or specific google map view based on Google Maps? which one is do you mind? This question is the most fundamental question we need to determine in which direction to provide the API.

change to GoogleMapView

rookiejava · 2019-04-15T05:25:39Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/MapViewRenderer.cs

+            Load();
+        }
+
+        void OnLoadError(object sender, global::Tizen.WebView.SmartCallbackLoadErrorArgs e)


Select whether to use private keyword or not.

rookiejava · 2019-04-15T05:26:04Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/MapViewRenderer.cs

+        {
+            _maphtml = CreateMapViewScript();
+            var baseUrl = default(string);
+            //Log.Debug(FormsCircularUI.Tag, $"html:{_maphtml}, baseUrl:[{baseUrl}]");


rookiejava · 2019-04-15T05:30:50Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/MapViewRenderer.cs

+            base.Dispose(disposing);
+        }
+
+        private void UpdateMapOption(bool obj)


when obj parameter used?

remove this code.

rookiejava · 2019-04-15T06:05:33Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/Map/MapService.cs

+
+namespace Tizen.Wearable.CircularUI.Forms.Renderer.Map
+{
+    public class MapService


GoogleMapService?

MapService is only for Geocoding API. I deleted this class

rookiejava

Please do not change the file mode (644 -> 755). If you use samba, then check your configuration for default file mode.

rookiejava · 2019-04-16T03:49:20Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapOption.cs

+        /// <summary>
+        /// Gets or sets a boolean value that indicates whether zoom control is visible.
+        /// </summary>
+        public bool IsVisibleZoomControl { get; set; }


IsZoomControlVisible

rookiejava · 2019-04-16T03:49:44Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/CircularUI.cs

@@ -24,10 +24,15 @@ public static class FormsCircularUI

        public static bool IsInitialized { get; private set; }

-        public static void Init()
+        public static void Init(string apiKey = null)


Keep the original one and add new Init() having apiKey as below to avoid binary-level break.

public static void Init(string apiKey) { }

rookiejava · 2019-04-16T03:51:00Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapOption.cs

+        /// <summary>
+        /// Gets or sets a boolean value that indicates whether zoom and pan interaction is enable.
+        /// </summary>
+        public bool IsEnableGestureHandle { get; set; }


What about HasGestureEnabled instead?

rookiejava · 2019-04-16T04:09:10Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapOption.cs

+        /// <summary>
+        /// Gets or sets a boolean value that indicates whether zoom and pan interaction is enable.
+        /// </summary>
+        public ZoomControlPosition ZoomControlPosition { get; set; }


What about MapControlPositon?

ZoomControlPosition is more clear than MapControlPositon. each Map control can place separately.

rookiejava · 2019-04-16T04:17:27Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapView.cs

+        /// <summary>
+        /// An IList of the Pins on this MapView.
+        /// </summary>
+        public IList<Pin> Pins


What happen if user set Pin.Type? and Can user use Clicked event for these Pin?

rookiejava · 2019-04-16T04:20:48Z

src/Tizen.Wearable.CircularUI.Forms/ZoomControlPosition.cs

+        /// <summary>
+        /// The control should be placed along the bottom right of the map
+        /// </summary>
+        RightBottom = 5


If I remember correctly, there are more control position in Google Maps, isn't it? Any reasons why we providing only 5 position?

Other positions are only meaningful when used with other map controls, and top_center / bottom_center is not included because zoom control is displayed vertically.

rookiejava · 2019-04-16T04:25:04Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapView.cs

+        /// <summary>
+        /// Set GoogleMapOption value to MapView.
+        /// </summary>
+        public void SetMapOption(GoogleMapOption value)


How do you feel about Show() or Load() instead?

SetMapOption is clear than show and load. show and load means that view only show after show() or Load() method called. Even if user didn't call SetMapOption(), GoogleMapview show default map.

rookiejava · 2019-04-16T04:29:48Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapView.cs

+        public void SetMapOption(GoogleMapOption value)
+        {
+            MapOption = value;
+            LoadMapRequested?.Invoke(this, EventArgs.Empty);


Why don't use MapOptionEventArgs ?

For convenience of implementation, only forward the event. The actual GoogleMapOption value is passed to MapOption.

src/Tizen.Wearable.CircularUI.Forms.Renderer/GoogleMaps.cs

rookiejava · 2019-04-17T00:25:51Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/GoogleMaps.cs

+            IsInitialized = true;
+        }
+
+        internal static string GetKey()


internal -> public

rookiejava · 2019-04-17T00:26:38Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/GoogleMaps.cs

+        public static void Init(string apiKey)
+        {
+            if (IsInitialized)
+                return;


Is there no chance to change apiKey?

No. apikey is set first init

rookiejava · 2019-04-17T00:36:28Z

src/Tizen.Wearable.CircularUI.Forms.Renderer/CircularUI.cs

+
+        public static void Init(string apiKey)
+        {
+            if (IsInitialized) return;


We need to discuss more about the initialization process something like below.

Need to validate whether GoogleMaps 's initialization process is success or not. (including validate the apiKey value)

If above step OK, just invoke Init()

Or

Check IsInitialized first

Init the GoogleMaps with given apiKey

If above 2 steps are success, set IsInitialized to true

validating apikey is possible but it take a time(need async http request). It will affect app launching time. so I want to keep current status.

rookiejava · 2019-04-17T00:39:55Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapView.cs

+            MapOption = option;
+        }
+
+        [EditorBrowsable(EditorBrowsableState.Never)]


you may omit this line, or change the visibility of MapOption from internal to public.

rookiejava · 2019-04-17T00:40:27Z

src/Tizen.Wearable.CircularUI.Forms/GoogleMapView.cs

+                if (_option.Equals(value))
+                    return;
+                _option = value;
+


rookiejava · 2019-04-17T00:44:54Z

src/Tizen.Wearable.CircularUI.Forms/Marker.cs

+        /// <summary>
+        /// Gets or sets a location coordinate of Marker.
+        /// </summary>
+        public LatLng Location


what about Center?

or Position

Done (Location -> Position)

* [CircleStepper] add implementation and TC * Change new renderer for CircleListView. Now CircleListView add top and bottom padding automatically. * Add TwoButtonPage and Test * Fix Issue #13 Now ToolbarItem in CirclePage can Activate without Command. * Fix Invalid icon setter on CirclePage.ActionButton * [CircleStepper] remove Ratio property * modify Slider/ContextPopup/Check design doc * [CircleDateTimeSelector/CircleStepper] change name of Color property to MarkerColor * Rename Xamarin.Forms.Circular.Renderer to Xamarin.Forms.Circular.Tizen * Add LICENSE * Add nuspec file * Fix Xamarin.Forms.CircularUI.nuspec * Change Namespace and implement IRotaryEventReceiver Change Xamarin.Forms.CircularUI.Renderer to Xamarin.Forms.CircularUI.Tizen Add implementation for IRotaryEventReceiver to CirclePage. Add Test for IRotaryEventReceiver. * Fix reference Xamarin.Forms.Platform.Tizen * [CircleStepper] add TC for AbsolutLayout and modify TC for Grid * [CircleStepper] add StackLayout TC (#24) * [CircleStepper] add MarkerLineWidth and remove debug log (#25) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture (#26) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture * [CircleStepper] update property picture * [CircleStepper] update property picture * [CircleStepper] fix errata * Fix CircleListView's OnItemDisappear, OnItemAppear (#27) * [CircleStepper] fix issue where the marker position was wrong when assigning a nonzero number to value (#28) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture * [CircleStepper] update property picture * [CircleStepper] update property picture * [CircleStepper] fix errata * [CircleStepper] fix issue where the marker position was wrong when assigning a nonzero number to value * [CircleStepper] add listview for TCs (#30) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture * [CircleStepper] update property picture * [CircleStepper] update property picture * [CircleStepper] fix errata * [CircleStepper] fix issue where the marker position was wrong when assigning a nonzero number to value * [CircleStepper] add listview for TCs * Fix CirclePage NavigationBar issue (#29) * Fix NavigationBar issue If NavigationPage.HasNavigationBar is true. title text are truncated and circle object move down. * Add TwoButtonPopup doc and modify TwoButtonPage doc * [doc]modify some description * [TwoButtonPopup] add Toast TC (#31) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture * [CircleStepper] update property picture * [CircleStepper] update property picture * [CircleStepper] fix errata * [CircleStepper] fix issue where the marker position was wrong when assigning a nonzero number to value * [CircleStepper] add listview for TCs * [TwoButtonPopup] add Toast TC * Revert: Fix CirclePage NavigationBar issue (#29) (#32) * Fix NavigationBar issue If NavigationPage.HasNavigationBar is true. title text are truncated and circle object move down. * Add TwoButtonPopup doc and modify TwoButtonPage doc * [doc]modify some description * Revert : [TwoButtonPopup] add Toast TC (#34) * [CircleStepper] add StackLayout TC * [CircleStepper] add MarkerLineWidth and remove debug log * [CircleStepper] update doc to add property picture * [CircleStepper] update property picture * [CircleStepper] update property picture * [CircleStepper] fix errata * [CircleStepper] fix issue where the marker position was wrong when assigning a nonzero number to value * [CircleStepper] add listview for TCs * [TwoButtonPopup] add Toast TC * Revert : [TwoButtonPopup] add Toast TC * Revert : [TwoButtonPopup] add Toast TC * [Radio] add Radio API implementation and TC (#35) * Fix NavigationBar issue If NavigationPage.HasNavigationBar is true. title text are truncated and circle object move down. * Add TwoButtonPopup doc and modify TwoButtonPage doc * [doc]modify some description * [Radio] add Radio API implementation and TC * Change CircleListView method of getting row height (#36) Now CircleListView get row height from item first not header. Add TCs for it. * [doc] add Radio design document (#37) * [Toast] add sample for Toast using the DependencyService (#39) * [Toast] add sample for Toast using the DependencyService * Revert "[Toast] add sample for Toast using the DependencyService" This reverts commit 4130b2262a32a7576c34913b141085ea9a512133. * [Toast] add sample for Toast using the DependencyService * Revert "[Toast] add sample for Toast using the DependencyService (#39)" (#40) This reverts commit 67997d7. * Fix Crash on touch head or footer (#41) Remove printing for debugging in header/footer renderer * Fix Unmatched Size error in TwoButtonPage (#42) Update X.F.Platform.Tizen version for new overridable method. Fix Unmatched Size error in TwoButtonPage * [Radio]add Value property and TC (#43) * [doc] modify Radio design document (#44) * [CircleDateTime] fix datetime not updating issue and Time format (#45) * [CicleSlider] fix value not updating issue (#46) value is not updated when bezel is rotating. * Fix exception when Group is used with CircleList (#50) * [CircleStepper] add LabelFormat on document (#48) * [CircleStepper] add LabelFormat property (#51) * [CircleStepper] add LabelFormat property implementation * Add Confirm Popup Effect and Update Document (#52) * fix missing feature of diagram by merge (#53) * Version up to X.F Platform Tizen 2.5.0.121934 (#54) Change Context.MainWindow to Forms.NativeParent Fork CircleScrollViewRenderer from original ScrollViewRenderer * Add comment and code example for API reference (#56) * Change CirclePage (add feature, change renderer) (#57) Add ActionButtonItem for Visibility, Enable/Disable from MenuItem Change CirclePageRenderer to don't use Layout. it only use one box. * Fix TCCirclePage build (#58) * Fix CirclePage ToolbarItems & ActionButton (#59) * Add comments for API reference (#61) - CirclePage, CircleDateTimeSelector, CircleStepper, CircleSurfaceItem, ConfirmPopupEffect, CircleToolbarItem, RotaryEventHandler, TwoButtonPage * fix context-popup display issue (#60) * Fix more option position on first page (#64) * Add Toast API and document (#65) * update comments to match API doc guide and fix AcceptCommandParameter issue (#67) * update comments to match API doc guide and fix AcceptCommandParamter issue of ConfirmPopupEffect * Update comment to fix commented issues - add 'The' - change to small letter in 'Bazel Action' - change the unclear phrase * Update comments and remove code example with XAML (#68) * Fix CirclePage (#69) - Fix inactive CircleSurfaceItems on initialize CirclePage. - Fix inactive Icon on ActionButton. - Fix inactive clicked event on ActionButton. - Fix Page Layout TwoButtonPageRenderer. * Change ActionButton z order to under CircleSurface (#70) * Fix Header, Items insert order in CircleListView (#73) * Change MoreOption and ActionButton in CirclePage (#74) From now, MoreOption and ActionButton is created on time when using. * [CircleDateTimeSelector] add SetFieldVisibility() and remove SetFieldLimit() (#72) * remove useless ConfirmArgument file (#75) * add performance TC at WearableUIGallery (#76) * Add lifecycle managing class for Watchface. (#77) - Add lifecycle managing class for Watchface. - Add Test Sample for Watchface class - Update xamarin.forms.platform.tizen version * [CircleDateTimeSelector] modify TC for FieldVisibility function (#78) * remove useless code and fix typing error of comment (#79) * Fix unchanged clock in watchface sample (#80) * add InfomationPopup and rename TwoButtonPopup to ConfirmationPopup (#81) * add InfomationPopup and rename TwoButtonPopup to ConfirmationPopup * add Information & Confirmation Popup design doc * Fix typo at InformationPopup (#83) * Fix NullReferenceException at Popup Menuitem (#84) * Fix ActionButton exception on CirclePage reloaded (#85) * Fix CirclePage Dispose function. (#86) * Add CircleStackLayout (#93) CircleStackLayout can layout the children fit into circle shape. * Change Xamarim.Forms and Platform.Tizen to latest (#94) * Add Ambient mode at SimpleTextWatchface (#95) * Add Ambientmode at SimpleTextWatchface * fix ambient tick update issue and remove log * rename Namespace Xamarin.Forms.CircularUI to CircularUI * Add some information to readme and fix nuspec. (#97) * fix nuspec errata (#98) * fix nuspec errata #2 (#99) * Add additional md files (#100) - Add PULL_REQUEST_TEMPLETE.md - Add CODE_OF_CONDUCT.md - Add HOW_TO_MAKE_TIZEN_XAMARIN_FORMS_APP_WITH_CIRCULAR.md - Add additional info at README.md * add copyright and license on header of code file (#101) * Change XF version to 3.1.0.373384-nightly (#103) * Add docfx files for documentation (#104) * change license ( Apache -> flora ) (#105) * Fix broken link in documentation first page. (#106) * Change capture images to remove text in Korean. (#107) * Change API reference link to local DocFX (#108) * Change namespace Tizen.Wearable.CircularUI.Forms (#110) * change Init() namespace and guide/test app (#111) * Fix build error of nuget pkg (#113) * change Init() namespace and guide/test app * Fix build error buiding nuget pkg * Add CirclePage guide and XUIComponents sample (#114) * fixing the issue that toast popup was not disapeared (#116) * change namespace of init and fix link of index.md (#117) * Fix #115 and Update TwoButtonPage & CircleSurfaceEffectBehavior (#118) * Fix the bug #115 * Update TwoButtonPage & CircleSurfaceEffectBehavior Change TwoButtonPage - Remove Title area from TwoButtonPage. - Now TwoButtonPage.Content cover all area in page. But it cover area between two buttons if Overlap is set. - Add Overlap feature to TC for TwoButtonPage. Add CircleSurfaceEffectBehavior - This behavior makes a page can has widgets require CircleSurface. Add TC for CircleList adding or removing item on runtime. - It use CircleSurfaceEffectBehavior and TwoButtonPage * Apply updated screenshot of 'How to make ~' with new namespace (#119) * Add TwoButtonPage and Confirmation/Information/Context/Toast popup guide. (#120) * Add some Controls guide and fix some code * fix TwoButtonPage code error and CirclePage warrning * Change Image Pixel size (#121) * Add some Controls guide and fix some code * change image pixel size and image code * Fix NaN exception of CircleStackLayout (#122) NaN is appear on Child Minimum is bigger than radius of layout. This patch fix it. * Add PopupEntry (#123) * Add PopupEntry PopupEntry is the Entry but it makes new screen on editing text. It help to edit text in circular screen. * Change Xamarin.Forms Version to Nightly Change Xamarin.Forms version to 3.1.0.433950-nightly * Fix PopupEntry blank screen bug (#124) This patch prevents to pop up the input layer alone without IME. * Add Guides to docfx generating document (#125) - Add guides to docfx config - Change name HOW_TO_MAKE_TIZEN_XAMARIN_FORMS_APP_WITH_CIRCULARUI to Quickstart * Add Toast/Radio guide (#126) * add guides for UI components (#127) - CircleDateTimeSelector - CircleListView - CircleScrollView - CircleStackLayout - CircleStepper - ConfirmPopupEffect - IndexPage * Add and modify guide doc * update link and remove useless descriptions * Add PopupEntry guide * Change solution file position for test build * Add PopupEntry Guide to TOC (#10) * Change Xamarin Forms dependency to nuspec (#12) * fix wrong link and typo at guide (#13) * fix name of ConfirmPopupEffect at TOC * fix wrong link and typo and remove '\' for endline * Add csproj for create nupkg (#14) * Fix Check.md in the guide (#16) check issue #15 * Update doc- add example desctipion, add link, fix bug on PopupEntry (#17) * remove emphasis effect of text with link to distinguish it from text without link (#18) * Fix typo at guides and index.md (#21) * Fix typo at guides and modify index.md * Fix typo at guide and index * Fix Issue #22 (#23) Fix incorrect signature event listener that linked in xaml. * Fix index.md and README.md * Add sample guide on README.md (#24) * add guide for myget package source (#25) * Update images and description of QuickStart.md (#26) * Fix incorrect capitalization and lowercase letters (#27) Fix incorrect capitalization and lowercase letters add remark and link * Add Embeddable Build Status Icon to README (#28) * Fix incorrect words (#30) * Fix NullReferenceException of ConfirmationPopup and add description of Menuitem limitation (#31) * Fix Null Exception of ConfirmationPopup fix NullReferenceException if Confirmation second menu has no icon. add description about menuitem property limitation. * Fix typo * Add dot at summary (#32) * Fix Null Exception of ConfirmationPopup fix NullReferenceException if Confirmation second menu has no icon. add description about menuitem property limitation. * Fix typo * Add dot at summary * Remove ContextPopup (#33) * Fix Null Exception of ConfirmationPopup fix NullReferenceException if Confirmation second menu has no icon. add description about menuitem property limitation. * Fix typo * Remove ContextPopup * Rename from ConfirmationPopup to TwoButtonPopup * Rename from ConfirmPopup to TwoButtonPopup at sample app (#34) * Add CircleSliderItem guide and Slider/Progressbar Link (#35) * Add CircleSliderItem guide and Slider/Progressbar Link * rename slider/progressbar link * Fix issue of not displaying text at progress popup. (#36) * ConfirmPopupEffect to ContextPopupEffectBehavior (#37) Change Effect to Behavior (with internal Effect) Fix documentation and relative files. * Update guide to apply English language check (#38) * Update guide to fix bugs (#39) * Apply result of English language check on CircleSliderSurfaceItem of CirclePage (#40) * Modify incorrect comments and code example of CircleSurfaceEffectBehavior (#41) * update CircularUI nuget version (#42) * Fix CirclePage to applies modified BindingContext (#43) Applies the modified BindingContext to CircleSurfaceItems. * Remove deprecated class and fix README, Sample (#44) * Add screenshots for each widget to data pptx (#45) * Fix overlapped text issue in Multiline TC on XUIComponents (#47) * Change RotaryFocusObject setter to public (#48) * modify IndexPage and Radio guide (#49) * Add TC for CirclePage.CircleSurfaceItems (#50) * Add TC for CirclePage.ActionButton (#51) * Add Test for RotaryFocus Properties (#52) TCRotaryFocus test switching RotaryFocusObject and RotaryFocusTargetName. * Change CircleSlider MaxValue to 11 (#53) * Add testcase for TwoButton/Information/Toast popup and Radio/ IndexPage (#54) * Add CircleSurfaceItem TCs (#55) * Remove RotaryFocusTargetName (#56) Remove RotaryFocusTargetName from CirclePage Remove RotaryFocusTargetName from CircleSurfaceEffectBehavior * Remove RotaryFocusTargetName at XUIComponents sample (#57) - remove RotaryFocusTargetName and replace to RotaryFocusObject - fix check Icon selecting issue when scroll up genlist. (add HasUnEvenRow) * Add TC for CircleStepper and ContextPopupEffectBehavior (#58) * Add Tcs for CircleProgressBar and ActionButtonItem (#59) Add TC for ActionButtonItem properties Add TC for CircleProgressBarSurfaceItem.Value * Add some features for missed API (#60) Use CircleToolbar.SubText property in TCCirclePage Use static properties in TCInformationPopup * Update screenshot of CircleStepper guide (#61) * Modify TCs CtxPopupEffect/CircleSurfaceItems/TwoButtonPopup (#62) - Modify ContextPopupEffectBehavior TC - Add some test for missed APIs. - rename CircleSurfaceItem TC * Fix y position of BottomOfView of ContextPopupEffectBehavior (#63) * Change Dismiss() from hide popup to dimiss and remove all resources on TwoButton/Information/Toast popup (#64) - change Dismiss() from hide pop-up to dismis pop-up. - dispose all resource when called Dissmissed Event handler. - change TwoButtonPopup/InformationPopup TCs follow to behavior change. * fix issue that not applying Value and BarAngle on CircleSliderSurfaceItem (#65) BarAngle and Value is interconnected. Each bindable object should be changed follow to other value changed. * Fix CircleSurfaceEffectBehavior implementation (#66) Now give rotary focus to object on page appearing. Fix it does not work with IRotaryEventReceiver. * Add Tests for unused API (#67) Change Overlap property to SetValue method in TCTwoButtonPage Add Test for CircleDateTimeSelector * Add protected methods TCs for CtxPopupEffect (#68) * fix display issue of ContextpopupEffectBehavior (#69) If the context popup is located at the bottom of the window, a scroll bar and popup border is shown. calibrate y postion of offset for prevent displaying over window. * Add IsSelected in SelectedEventArgs class for Radio (#70) * Fix issue of IndexPage and add TC (#71) - Fix issue of not applying CurrentPage just after Initialize. this is race condition issue. add check code (_isUpdateCarousel) - change workaround implements code to latest Xamarin implementation. - Add multiPage templete TC. * Modify CtxPopupEffect TC4 to handle tap event (#72) * Change Xamarin Forms version to release (#73) * Fixed incorrect dependency in nuspec file. (#75) * change package source guide from myget to nuget org (#74) * [CircleStepper] fix position issue of ':' (#77) * fix issue of transparent bg of Popup in PopupEntry (#78) * fix issue of transparent bg of Popup in PopupEntry * Update PopupEntry.md * [CircleStepper] Add Title property to match latest UX guide (#79) * [Quick start] Update guide to use template (#80) * [QuickStart] fix link error for template (#82) * Add guide for Localization for Tizen Xamarin.Forms app (#83) * Add Localization guide to guide toc (#84) * Add More documents (#85) Package Signing - Installing certificate Extension - Creating certificates - Permit device to install Apps - Managing certificate profile Testing Your App on Gear Move Localization to under the App Basics * [Quickstart] Separate Tizen XAML App template doc from QS document (#86) * [QuickStart] Replace xaml code to cs file (#87) * [Library list] Add 3rd party library list (#88) * [XUIComponent] Add comments (#89) * Add Comment and modify XUIComponents (#91) - Add and modify comment - modify codes for fixing StyleCop warnning. - change Entry TC from Entry to PopupEntry. - Update nuget version for PopupEntry issue. * [XUIComponents] change Tizen.NET version and add screen_shot (#92) * [WearableUIGallery] add icon change testcase for TwoButtonPage (#94) * [WearableUIGallery] add icon change testcase for TwoButtonPage * fix codacy review error * Add CancelEffectProperty to CircleListView (#93) CancelEffectProperty prevent the header and footer don't apply the fish eye effect. * Clean the code catched by codacy (#95) * Clean the code catched issues by codacy (#96) * Fix the guide and a test for IRotaryEventReceiver (#98) * Fix a bug in RotaryEventReceiver Test fixed a problem that only moves once on rotation * Fix guide for IRotaryEventReceiver. Add more information about CirclePage.RotaryFocusObject. * Apply HorizontalTextAlignment to PopupEntry. Fixes #99 (#105) Now HorizontalTextAlignment is working on the Entry in Popup. It resolves issue #99 * Fix first scroll issue in IndexPage (#106) When scroll page from first page to second page. - CurrentPageChanged event is not raised - Page indicator is still indicating first index. * Add warnning at CircleListView and modify listview TCs (#107) * FIx CircleScroller and PopupEntry Issues (#108) * Fix Scroller for add padding * Apply padding feature to CircleScrollView * Fix PopupEntry Issues Fix removed TextStyle after recreated the PopupEntry. #81 Fix TextChanged and Completed events. #101 Fix Keyboard. #104 * Merge duplicated case from VisiblePolicy * Remove useless conditions from PopupEntry * Resolve Codacy Issues (#109) * Dispose SmartEvent in Dispose of CircleScrollViewRenderer * Remove unneeded init value and temporary prints * Add explaining comment to blank UpdateLayout of TwoButtonPageRenderer * Remove unused parameter from CircleStackLayout.RecalcForCirlce * Remove unneeded init value and unused local variable * [Doc] Apply review result of doc team (#110) * Fix Exception at terminating on Watchface without Application (#111) * Add Codacy badge (#112) * Add a document for using the custom font. (#113) * Add a reference of YiSunShin font. (#114) * Fix some link and typo at guide (#116) * Fix Undeleted ActionButton in CirclePage (#117) and TC refactoring (#118) * Fix Undeleted ActionButton in CirclePage (#117) * Add TCListView to WearableUIGallery TCDescribe depth is change to ListView automatically. * Update custom font document. (#121) * Fix Issue #119 (#122) * Add TC for Header and group item * Fix Issue #119 Now, CircleListView Header has a predefined minimum height for each case that is before group header or not. * Fix issue of CircleScrollView content size (#125) - fix resize issue when remove child of scroll. - add more tc for CircleScrollView * Update Xamarin.Forms version to 3.2.0 (#126) * Add color property for bar and button and Popup (#132) * Fix not updating issue of PopupEntry (#133) -PopupEntry editor is not updating Element text that is inserted by code. -Add event handler for base entry Control, and check whether editor is same as control's text. * Add Package Icon (#134) * Add bad case and note to the document of CircleStackLayout (#135) * Add Appium TestScript and AutomationId for WearableUIGallery (#140) * Add Appium TestScript and AutomationId for WearableUIGallery * Fix build error and codacy issue * Add TwoButtonPopup Command TC (#141) * Add Appium TestScript and AutomationId for WearableUIGallery * Fix build error and codacy issue * Add TwoButton Command TC * Add tip and description for custom font guide (#142) * Add Appium TestScript and AutomationId for WearableUIGallery * [Appium]Fix TC for running in tizen emulator (#144) [Appium]Fix TC for running in tizen emulator * [Appium] apply device name and IP of CI appium server (#146) * Possible fix for #147 - (#148) * added test page demonstrating indexpage issue * possible indexpage fix * [Appium] Fix some issue for UI Automation test (#149) * [Appium]change scroll speed (#151) * Update Xamarin.Forms Version V4.0-pre2 (#153) * Fix #154 issue, Header HeightRequest and RowHeight is not set (#155) * Update Xamarin.Forms version 3.5.0.129452 and revert Tizen.NET 5.0.0 update (#157) * Add UI Automation test guide (#158) * Fix some markdown issue (#159) * Fix some markdown issue * Fix markdown issue 2 * Fix markdown issue 2 (#160) Image is not displayed in docfx site. but it work properly in github. * [CircleScroller]Fix the issue that can't set ScrollBarVisibility (#164) * Deprecate Marker related APIs (#166) * Deprecate Marker related APIs * Suppress warning and remove markercolor TC * [IndexPage] fix focus issue in IndexPage(#161) (#167) * Update issue templates * Adds MediaView (#170) * Update index.md * Mediaview dev guide addded (#171) * Update Tizen.Wearable.CircularUI.nuspec * Update test scroll speed (#172) * Add Tizen.Appium package reference to WearableUIGallery (#175) * Revert "Add Tizen.Appium package reference to WearableUIGallery (#175)" (#177) This reverts commit e6fff00. * [UITEST]apply Tizen.Appium.Forms 1.0.0 (#176) * [CirclePage] fix MoreOption launching time issue (#178) * [CirclePage] fix moreoption launching time issue * change nuget version and fix wrong IP * [UITest] change appium server URI * Fixed the wrong parameter about 3rd parameter of CreateAttached method (#179) * Add the IsPopupOpened property of PopupEntry (#180) * Add IsPopupOpened property of PopupEntry * Add the TC for checking the IsPopupOpened property of PopupEntry * [Map]Adds GoogleMapView (#183) * [Map]Add Map APIs (first impl) * Modified following to PR review * Fix build error * Modified following to second PR review * Modified following to third PR review * remove unused nuget package * Adds CircularUI log Tag in Renderer (#184) * [doc]Adds guide for GoogleMapView (#186) * [CirclePage]Fix Actionbutton displaying issue on Multipage (#187) * [TestApp]Adds license sentense and remove unnecessary using codes and tab (#188) * Fix index.html of document (#189)

hadihashem · 2020-04-02T08:55:44Z

Hello @jkpu
Can you please explain how to add objects to a GoogleMapView (such as drawing a polyline)?
Thank you in advance
Regards

jkpu · 2020-04-02T09:23:52Z

Hello @hadihashem
GoogleMapView only support drawing simple google javascript map in Tizen .NET app becaues Tizen has no map service and own Map API(Tizen native provide wrapping api of Here Map API). This API is not support other feature such as draw route or other google map features.
Anyway, drawing polyine or any drawing object is not supported in GoogleMapView yet. if you want to draw map, you should use Xamarin.Form.WebView and javascript . you can draw polyline in javascrip code.

[Map]Add Map APIs (first impl)

f35dae3

jkpu requested a review from rookiejava April 11, 2019 08:39

rookiejava reviewed Apr 15, 2019

View reviewed changes

jkpu added 2 commits April 15, 2019 18:57

Modified following to PR review

2cd4339

Fix build error

04e9b12

rookiejava reviewed Apr 16, 2019

View reviewed changes

Modified following to second PR review

cb708c6

jkpu changed the title ~~[Map]Adds Map APIs (first impl)~~ [Map]Adds GoogleMapView Apr 16, 2019

rookiejava reviewed Apr 17, 2019

View reviewed changes

jkpu added 2 commits April 17, 2019 11:00

Modified following to third PR review

7b99724

remove unused nuget package

26d9aca

jkpu merged commit dea276a into Samsung:master Apr 17, 2019

rookiejava added the enhancement New feature or request label Apr 23, 2019

[Map]Adds GoogleMapView #183

[Map]Adds GoogleMapView #183

Conversation

jkpu commented Apr 11, 2019 • edited Loading

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rookiejava left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkpu Apr 16, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hadihashem commented Apr 2, 2020

jkpu commented Apr 2, 2020

jkpu commented Apr 11, 2019 •

edited

Loading

jkpu Apr 16, 2019 •

edited

Loading