This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Icon minimumsize of NavigationView * Update test apps
* Add NavigationDrawer * Separate NaivgationDrawer from ShellRenderer * Update NavigationDrawer * Add NavigationDrawer.IconHeight * Update NavigationDrawer and ShellRenderer * Fix NavigationDrawer disappearing issue * Update NavigationDrawer to have shell item content
myroot
commented
Jan 28, 2020
using XForms = Xamarin.Forms.Forms; | ||
using XShell = Xamarin.Forms.Shell; | ||
|
||
[assembly: ExportRenderer(typeof(Tizen.Wearable.CircularUI.Forms.CircularShell), typeof(Tizen.Wearable.CircularUI.Forms.Renderer.ShellRenderer))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
[assembly: ExportRenderer(typeof(Tizen.Wearable.CircularUI.Forms.CircularShell), typeof(Tizen.Wearable.CircularUI.Forms.Renderer.ShellRenderer))] | |
[assembly: ExportRenderer(typeof(XShell), typeof(Tizen.Wearable.CircularUI.Forms.Renderer.ShellRenderer))] |
@shyunMin As we discussed yesterday, please let me know if both |
@rookiejava I've checked latest codes |
rookiejava
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Bugs Fixed
API Changes
Added:
Create a CircularShell Application
AppShell.xaml
AppShell.xaml.cs
Behavioral Changes
ShellFlyout
->![](https://user-images.githubusercontent.com/1029155/73242707-0a0c8700-41e9-11ea-8660-627245655785.gif)
Top tabs
-> ![](https://user-images.githubusercontent.com/1029155/73243208-62905400-41ea-11ea-8c2f-933c13325257.gif)
CircularShell provide flyout navigation menu, it slideup from bottom
![flyout-open-close](https://user-images.githubusercontent.com/1029155/73240032-1b519580-41e1-11ea-8634-2d0b5fb703d1.gif)
Navigating with flyout navigation menu
![flyout-navigation](https://user-images.githubusercontent.com/1029155/73241856-aa14e100-41e6-11ea-89b6-5aca9cc4dba8.gif)
When content was touched, flyout navigation bar was automatically hide
![flyout-auto-hide](https://user-images.githubusercontent.com/1029155/73240113-581d8c80-41e1-11ea-87ee-9a8c729c7a2e.gif)
App developer can disable flyout navigation bar with
![flyout-enable-disable](https://user-images.githubusercontent.com/1029155/73240182-8307e080-41e1-11ea-9062-16506fd7567b.gif)
FlyoutBehavior
propertyApp developer can change flyout navigation bar icon with
![flyout-icon-change](https://user-images.githubusercontent.com/1029155/73240240-ba768d00-41e1-11ea-8e4e-1c7d868ad9db.gif)
FlyoutIcon
propertyFlyout navigation menu can close with back button and swipe down gesture
![flyout-close-with-back](https://user-images.githubusercontent.com/1029155/73240277-e0039680-41e1-11ea-9ef4-7e7b0482e674.gif)