This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Fix year label issue in CircleDateTimeSelector #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myroot
reviewed
Apr 10, 2020
| @@ -102,14 +102,14 @@ void UpdateValueType() | |||
| { | |||
| if (null != Control && null != Element) | |||
| { | |||
| Control.Format = "%d/%b/%Y%I:%M%p"; | |||
There was a problem hiding this comment.
%I:%M%p is not need on Date picker
And I think we provide locale preferred formatting
There was a problem hiding this comment.
done. remove %M%P in Date type.
myroot
approved these changes
Apr 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix year label issue in CircleDateTimeSelector in latest Tizen 5.5 SPIN binary.
Format was not applied when ValueType is DateTimeType.Date.
Bugs Fixed
Fix issue #267
[before]
[after]
API Changes
None
Behavioral Changes
None