Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] If the view had focus when it was unparented, the focus is cleared. #4654

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

JoogabYun
Copy link
Contributor

Description of Change

When the view is unparented, the focus is not cleared. So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.

API Changes

@JoogabYun JoogabYun force-pushed the Focus_1013 branch 2 times, most recently from ce70ab2 to 6395669 Compare October 13, 2022 04:44
@JoogabYun JoogabYun marked this pull request as ready for review October 13, 2022 04:46
…red.

When the view is unparented, the focus is not cleared.
So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoogabYun JoogabYun merged commit 6dd1935 into Samsung:DevelNUI Oct 13, 2022
dongsug-song pushed a commit to dongsug-song/TizenFX that referenced this pull request Oct 13, 2022
…red. (Samsung#4654)

When the view is unparented, the focus is not cleared.
So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
dongsug-song pushed a commit that referenced this pull request Oct 13, 2022
…red. (#4654)

When the view is unparented, the focus is not cleared.
So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
@JoogabYun JoogabYun deleted the Focus_1013 branch July 27, 2023 04:10
JoogabYun added a commit to JoogabYun/TizenFX that referenced this pull request Jul 17, 2024
JoogabYun added a commit that referenced this pull request Jul 23, 2024
JoogabYun added a commit to JoogabYun/TizenFX that referenced this pull request Jul 23, 2024
JoogabYun added a commit that referenced this pull request Jul 23, 2024
JoogabYun added a commit to JoogabYun/TizenFX that referenced this pull request Jul 24, 2024
JoogabYun added a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants