-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] If the view had focus when it was unparented, the focus is cleared. #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoogabYun
force-pushed
the
Focus_1013
branch
2 times, most recently
from
October 13, 2022 04:44
ce70ab2
to
6395669
Compare
JoogabYun
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho and
everLEEst
as code owners
October 13, 2022 04:46
…red. When the view is unparented, the focus is not cleared. So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
jaehyun0cho
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hinohie
approved these changes
Oct 13, 2022
dongsug-song
pushed a commit
to dongsug-song/TizenFX
that referenced
this pull request
Oct 13, 2022
…red. (Samsung#4654) When the view is unparented, the focus is not cleared. So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
dongsug-song
pushed a commit
that referenced
this pull request
Oct 13, 2022
…red. (#4654) When the view is unparented, the focus is not cleared. So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
JoogabYun
added a commit
to JoogabYun/TizenFX
that referenced
this pull request
Jul 17, 2024
… is cleared. (Samsung#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
JoogabYun
added a commit
that referenced
this pull request
Jul 23, 2024
… is cleared. (#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
JoogabYun
added a commit
to JoogabYun/TizenFX
that referenced
this pull request
Jul 23, 2024
… is cleared. (Samsung#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
JoogabYun
added a commit
that referenced
this pull request
Jul 23, 2024
… is cleared. (#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
JoogabYun
added a commit
to JoogabYun/TizenFX
that referenced
this pull request
Jul 24, 2024
… is cleared. (Samsung#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
JoogabYun
added a commit
that referenced
this pull request
Jul 24, 2024
… is cleared. (#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When the view is unparented, the focus is not cleared. So, when app re-add the view and SetCurrentFocusView, app do not receiving the FocusGained event.
API Changes