[NUI] Remove the legacy AccessibilityActivate code #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CSharp_Dali_ViewImpl_AccessibilityActivate` was removed in 2018 lol
However, at that time, NUI codes couldn't be removed together (Not sure)
- The reason `ViewImpl_AccessibilityActivate` was removed is
`Remove functions which using internal apis
Some binding functions use internal apis.
It caused error when dlopen csharp binder.`
- User can use Activated event with `View.AccessibilityActivated`
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Seoyeon2Kim
requested review from
hyunjushin,
dongsug-song,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
taehyub
approved these changes
Jul 23, 2024
감사합니다 :) |
JoogabYun
pushed a commit
to JoogabYun/TizenFX
that referenced
this pull request
Jul 23, 2024
- `CSharp_Dali_ViewImpl_AccessibilityActivate` was removed in 2018 lol
However, at that time, NUI codes couldn't be removed together (Not sure)
- The reason `ViewImpl_AccessibilityActivate` was removed is
`Remove functions which using internal apis
Some binding functions use internal apis.
It caused error when dlopen csharp binder.`
- User can use Activated event with `View.AccessibilityActivated`
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
JoogabYun
pushed a commit
that referenced
this pull request
Jul 23, 2024
- `CSharp_Dali_ViewImpl_AccessibilityActivate` was removed in 2018 lol
However, at that time, NUI codes couldn't be removed together (Not sure)
- The reason `ViewImpl_AccessibilityActivate` was removed is
`Remove functions which using internal apis
Some binding functions use internal apis.
It caused error when dlopen csharp binder.`
- User can use Activated event with `View.AccessibilityActivated`
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
CSharp_Dali_ViewImpl_AccessibilityActivatewas removed in 2018 lol However, at that time, NUI codes couldn't be removed together (Not sure)The reason
ViewImpl_AccessibilityActivatewas removed isRemove functions which using internal apis. Some binding functions use internal apis. It caused error when dlopen csharp binder.View.AccessibilityActivatedAPI Changes