[PackageManager] Fix garbage collected delegate problem #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjhun
reviewed
Aug 29, 2024
| @@ -46,8 +46,8 @@ public class Package | |||
| private List<string> _privileges; | |||
| private int _installedTime; | |||
|
|
|||
| private Dictionary<IntPtr, Interop.PackageManager.PackageManagerSizeInfoCallback> _packageManagerSizeInfoCallbackDict = new Dictionary<IntPtr, Interop.PackageManager.PackageManagerSizeInfoCallback>(); | |||
| private int _callbackId = 0; | |||
| private static Dictionary<IntPtr, Interop.PackageManager.PackageManagerSizeInfoCallback> _packageManagerSizeInfoCallbackDict = new Dictionary<IntPtr, Interop.PackageManager.PackageManagerSizeInfoCallback>(); | |||
There was a problem hiding this comment.
Please use ConcurrentDictionary instead of Dictionary for thread safe
There was a problem hiding this comment.
Please ignore this comment.
The implementation already used lock for thread safe.
hjhun
approved these changes
Aug 29, 2024
SizeInfoCallback delegate can be collected by the garbage collector before receiving size info result Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
ilho159kim
force-pushed
the
fix_garbage_collected_delegate
branch
from
a01ecd6
to
609d072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
SizeInfoCallback delegate can be collected by the garbage collector before receiving size info result
API Changes
N/A