Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(make): add target for rebuilding images skipping cache #445

Merged
merged 2 commits into from
May 29, 2020
Merged

feat(make): add target for rebuilding images skipping cache #445

merged 2 commits into from
May 29, 2020

Conversation

k-dovgan
Copy link
Contributor

No description provided.

@k-dovgan k-dovgan requested a review from i-keliukh May 29, 2020 07:32
i-keliukh
i-keliukh reviewed May 29, 2020
View reviewed changes
tests/docker/Makefile Outdated Show resolved Hide resolved
i-keliukh
i-keliukh previously approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@i-keliukh i-keliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please create task for implementing 'make clean'.
At the moment, nonci mode run in repository leaves a lot of intermediate files, which prevent subsequent non-nonci run.

@k-dovgan
Copy link
Contributor Author

Also, please create task for implementing 'make clean'.
At the moment, nonci mode run in repository leaves a lot of intermediate files, which prevent subsequent non-nonci run.

#446

i-keliukh
i-keliukh approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@i-keliukh i-keliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is better.
Please submit.

@k-dovgan k-dovgan merged commit 2bb4f06 into master May 29, 2020
@k-dovgan k-dovgan deleted the add-rebuild branch May 29, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-keliukh i-keliukh i-keliukh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-dovgan @i-keliukh