Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced $(...) instead of legacy backticked ... #481

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Replaced $(...) instead of legacy backticked ... #481

merged 1 commit into from
Oct 29, 2019

Conversation

dyyim741
Copy link
Contributor

Backtick command substitution `...` is legacy syntax with several issues.

  1. It has a series of undefined behaviors related to quoting in POSIX.
  2. It imposes a custom escaping mode with surprising results.
  3. It's exceptionally hard to nest.

$(...) command substitution has none of these problems, and is therefore strongly encouraged.

@dyyim741
Replaced $(...) instead of legacy backticked ...
64ffea2 
Signed-off-by: DaYea Yim <dyyim@protonmail.com>
@clover2123
Copy link
Contributor

@dyyim741 Thanks for good PR. But tools/measure.sh is a legacy file and will be removed soon. I leave this comment FYI.

clover2123
clover2123 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksh8281 ksh8281 merged commit e1658b8 into Samsung:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clover2123 clover2123 clover2123 approved these changes

@ksh8281 ksh8281 ksh8281 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyyim741 @clover2123 @ksh8281