Add --jit flag to Benchmarker #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
jit_next
branch
3 times, most recently
from
7b3de18 to
91e26ba
Compare
zherczeg
force-pushed
the
jit_next
branch
6 times, most recently
from
c339958 to
101d5f5
Compare
|
Please rebase this patch based on the main branch |
GorogPeter
force-pushed
the
JitBenchmarkFlag
branch
from
cf2b717 to
7a9be59
Compare
zherczeg
requested changes
Nov 2, 2023
test/wasmBenchmarker/benchmark.py
Outdated
| if not os.path.exists(path): | ||
| print("invalid path for run") | ||
| exit(1) | ||
|
|
||
| tc_path = path + "/wasm/" + name + ".wasm" | ||
| print("TC path: " + tc_path) | ||
| result = subprocess.check_output(engine + " --run-export runtime " + tc_path, shell=True) | ||
| flags = "--jit --run-export runtime" if jit else "--run-export runtime" |
There was a problem hiding this comment.
This is a string duplication. Maybe this work:
"--run-export runtime" + (" --jit" if jit else "")
GorogPeter
force-pushed
the
JitBenchmarkFlag
branch
from
7a9be59 to
454673f
Compare
zherczeg
reviewed
Nov 4, 2023
test/wasmBenchmarker/benchmark.py
Outdated
| @@ -161,13 +164,13 @@ def run_wasm(engine, path, name): | |||
| return True | |||
|
|
|||
|
|
|||
| def measure_time(path, name, functon, engine=None): | |||
| def measure_time(path, name, functon, engine=None, jit=False): | |||
There was a problem hiding this comment.
This is not introduced here, but functon should be changed to function. Otherwise the patch ok.
GorogPeter
force-pushed
the
JitBenchmarkFlag
branch
from
454673f to
a1c22fa
Compare
clover2123
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.