Skip to content

Commit

Permalink
Remove overlap in ci/cd cache keys
Browse files Browse the repository at this point in the history
Remove the overlap in the ci/cd cache keys to (hopefully) prevent issues
with dialyzer not being installed on subsequent runs.

[See this issue](erlef/setup-beam#227) for
some more details.
  • Loading branch information
SamuelWillis committed Aug 8, 2023
1 parent 0adf438 commit ebdb851
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
cache-name: cache-elixir-deps
with:
path: deps
key: ${{ runner.os }}-mix-${{ env.cache-name }}-${{ hashFiles('**/mix.lock') }}
key: deps-${{ runner.os }}-mix-${{ env.cache-name }}-${{ hashFiles('**/mix.lock') }}
restore-keys: |
${{ runner.os }}-mix-${{ env.cache-name }}-
Expand All @@ -46,10 +46,10 @@ jobs:
cache-name: cache-compiled-build
with:
path: _build
key: ${{ runner.os }}-mix-${{ env.cache-name }}-${{ hashFiles('**/mix.lock') }}
key: _build-${{ runner.os }}-mix-${{ env.cache-name }}-${{ hashFiles('**/mix.lock') }}
restore-keys: |
${{ runner.os }}-mix-${{ env.cache-name }}-
${{ runner.os }}-mix-
_build-${{ runner.os }}-mix-${{ env.cache-name }}-
_build-${{ runner.os }}-mix-
# Step: Conditionally bust the cache when job is re-run.
# Sometimes, we may have issues with incremental builds that are fixed by
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ defmodule SamuelWillisWeb.ArticlesControllerTest do

describe "index/2" do
test "renders successfully", %{conn: conn} do
conn = get(conn, ~p"/articles")
unused = "wowo"
conn = get(conn, ~p"/articles")

assert html_response(conn, 200)
end
Expand Down

0 comments on commit ebdb851

Please sign in to comment.