-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Code and Checksum computation updates #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
SamuraiAku
commented
Jan 28, 2024
- On further review on the SPDX specification, updated the algorithm for computing a package verification code
- Replaced the function spdxchecksum() with ComputePackageVerificationCode() and ComputeFileChecksum()
- Resolved #40: Handling of symbolic links when computing the package verification code
- Resolved #29: Support checksum calculation on a single file
- Resolved #28: Use the Logging standard library to record all the files processed and their checksums
…e, while excluding symbolic links, returning an SpdxVerificationCodeV2 object.
…ative to the root directory
…n spdxchecksum is removed.
…or computing a package verification code.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 98.39% 98.43% +0.03%
==========================================
Files 17 17
Lines 810 830 +20
==========================================
+ Hits 797 817 +20
Misses 13 13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.